feat(cli): per-check prescan skip and warn overrides - #2899
Conversation
Let users target individual check ids instead of disabling the whole prescan, and document the full check catalog with ignore examples. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (14)
✨ Finishing Touches📝 Generate docstrings
Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_7c0cbb06-2630-4296-9c04-eaf3c6a6a141) |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 13 files
Confidence score: 3/5
- In
cli/src/schemas/sdk.tsandCapgoSDK.requestBuild,prescanSkip/prescanWarnare exposed in the SDK schema but not forwarded to the build handler, so callers can set options that are silently ignored and get unexpected prescan behavior in production builds — wire both fields throughrequestBuild(or remove them from the public schema until supported).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="cli/src/schemas/sdk.ts">
<violation number="1" location="cli/src/schemas/sdk.ts:383">
P2: The SDK schema now publicly advertises `prescanSkip`/`prescanWarn`, but `CapgoSDK.requestBuild` never forwards these fields into the underlying build handler (it only forwards `prescan` and `prescanIgnoreFatal`). An SDK caller who passes these overrides gets a silent no-op — the targeted check still runs and can still block the build — while the CLI path (via `--prescan-skip`/`--prescan-warn`) does honor them. Recommend forwarding the two arrays into `internalOptions` (mirroring lines 760-761) so the SDK honors per-check overrides the same way the CLI does, or dropping the fields from the schema until they're actually supported.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Merging this PR will not alter performance
Comparing 
Footnotes
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_6f1416b9-97bc-4bd7-91bc-0946782ba44b) |
Honor per-check overrides in CapgoSDK.requestBuild so SDK callers match the CLI path instead of silently ignoring schema fields. Co-authored-by: Cursor <cursoragent@cursor.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_9a02e768-7cc9-4d80-a287-3df37188116d) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
1 participant
Summary (AI generated)
--prescan-skip/--prescan-warnonbuild request(and--skip/--warnonbuild prescan) so users can ignore or downgrade specific check ids without disabling the whole scancli/webdocs/prescan-checks.mdxMotivation (AI generated)
Customers with intentional Capacitor
server.urlshells (e.g. Next.js remote web apps) hitios/capacitor-server-url-shipped. Global--no-prescan/--prescan-ignore-fatalhide every other check. Per-check CLI overrides are safer than a YAML ignore file.Business Impact (AI generated)
Unblocks legitimate remote-web Capacitor architectures for cloud builds without weakening prescan for everyone else. Reduces support friction around the Aug 14 enforcement rollout.
Test Plan (AI generated)
cd cli && bun test test/prescan/overrides.test.ts test/prescan/engine.test.tsbuild request --prescan-skip ios/capacitor-server-url-shippedstill runs other checksbuild request --prescan-warn ios/capacitor-server-url-shippedturns that error into a warningGenerated with AI
Made with Cursor
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.