fix(frontend): make breadcrumb links fill the header row - #2897
Draft
posthog-eu[bot] wants to merge 1 commit into
Draft
fix(frontend): make breadcrumb links fill the header row#2897posthog-eu[bot] wants to merge 1 commit into
posthog-eu[bot] wants to merge 1 commit into
Conversation
The breadcrumb bar in Navbar.vue is 64px tall but each crumb was bare inline text (px-1, no vertical padding), so most of the bar was dead space that looked like navigation. The final crumb was also a router-link pointing at the current route, so clicking it did nothing. - Give each clickable crumb an h-16 px-2 hit target so it fills the full height of the header row instead of a thin strip of text. - Render the last crumb as a plain span (aria-current="page") since a link to the current route is a no-op by construction. - Add a persistent underline affordance so crumbs read as links before hover. Generated-By: PostHog Code Task-Id: 40a34baf-3ba0-485f-92c7-447ee1cdaac4
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
The breadcrumb header renders on every app page as a 64px-tall bar, but only the small crumb text was clickable — the crumbs were bare inline
<router-link>s (px-1, no vertical padding) sitting in anh-16row, leaving most of the bar as dead space that looks like navigation. A second target was dead by construction: the last crumb linked to the route you're already on, so that click could never do anything.Test plan
/app/<app>/bundles) on desktop (lgbreakpoint).Screenshots
Mechanism:
<router-link px-1 text-sm>— hit target ≈ text height, thin strip centered in a 64px barflex items-center h-16 px-2— hit target fills the full row height<router-link>to the current route → dead click<span aria-current="page">→ no dead targethover:underlineonly — no affordance until you tryChecklist
bun run lint:backend && bun run lint.accordingly.
my tests
Created with PostHog Desktop from this inbox report.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.