fix(onboarding): hide API key placeholder while loading - #2877
fix(onboarding): hide API key placeholder while loading#2877WcaleNieWolny wants to merge 6 commits into
Conversation
GitHub Actions
Inactive
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 40 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe onboarding flow no longer displays ChangesOnboarding API key loading
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
Merging this PR will not alter performance
Comparing 
Footnotes
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/dashboard/AppOnboardingFlow.vue`:
- Around line 137-138: Keep the displayed command consistent with copyCliCommand
by ensuring builder setup commands pass the API key only through the -a flag in
the CLI argument construction and display logic around usesBuilderSetupCommand
and cliCommandArgs. Render the positional API key only for the i command, and
add an assertion covering the builder command display so it matches the copied
command.
- Around line 1251-1273: Replace the clickable command-panel divs in the API-key
branches of the onboarding flow with the appropriate DaisyUI d- interactive
primitive, removing the manual role, tabindex, and keyboard handlers while
preserving click-to-copy behavior and styling. Keep the loading branch as a
noninteractive status element, and apply the same change to the corresponding
panels near the other referenced sections.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: e912d911-7a3b-4606-a43d-5d795a7127d1
📒 Files selected for processing (3)
messages/en.jsonsrc/components/dashboard/AppOnboardingFlow.vuetests/app-onboarding-apikey-loading.unit.test.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
Cap-go/capacitor-updater(manual)
GitHub Actions
Inactive
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
GitHub Actions
Inactive
GitHub Actions
Inactive
|
Added 25cb64d to fix the full-page spinner reported for regular Create app flows. The resumed app now loads and renders before API-key provisioning starts; key creation continues asynchronously, with the CLI command card retaining its loading/copy-disabled state. Added a regression assertion and reran lint, backend lint, typecheck, 1,367 unit tests, and the production build. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/superpowers/plans/2026-08-06-nonblocking-resume-apikey.md`:
- Line 13: Change the “Task 1: Make resume API-key provisioning nonblocking”
heading to a level-2 Markdown heading so the document’s heading hierarchy
follows MD001.
In `@src/components/dashboard/AppOnboardingFlow.vue`:
- Around line 882-889: Update
src/components/dashboard/AppOnboardingFlow.vue:882-889 and loadResumeApp so the
resume path never awaits ensureApiKey(); invoke it only through the existing
handled background call after app loading, preserving error logging and the
toast while ensuring setup resumes render immediately. Update
docs/superpowers/plans/2026-08-06-nonblocking-resume-apikey.md:21-29 to require
coverage for resumeStep.value === 'setup' with a pending API-key promise. Update
tests/app-onboarding-apikey-loading.unit.test.ts:19-25 to test the setup-resume
path or inspect loadResumeApp directly, since the current onMounted slice misses
the nested await.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 665b16d5-455d-4075-bfa0-e6d202ebc376
📒 Files selected for processing (4)
docs/superpowers/plans/2026-08-06-nonblocking-resume-apikey.mddocs/superpowers/specs/2026-08-06-nonblocking-resume-apikey-design.mdsrc/components/dashboard/AppOnboardingFlow.vuetests/app-onboarding-apikey-loading.unit.test.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
Cap-go/capacitor-updater(manual)
GitHub Actions
Inactive
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
GitHub Actions
Inactive
|
1 participant
Summary
Test plan
Automated verification:
Screenshots
Not attached because this is a short-lived transition state. The repository Visual diff check and focused onboarding loading-state regression test validate the frontend change.
Checklist
Summary by CodeRabbit
New Features
Bug Fixes