Skip to content

Fix operator interface errors in CompositeOp and DebiasOp - #203

Open
cslht wants to merge 1 commit into
CambridgeCIA:mainfrom
cslht:fix/operator-interface-errors
Open

Fix operator interface errors in CompositeOp and DebiasOp#203
cslht wants to merge 1 commit into
CambridgeCIA:mainfrom
cslht:fix/operator-interface-errors

Conversation

@cslht

@cslht cslht commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Two fixes in the operators:

  • CompositeOp.range_shape returned wavelet.domain_shape (the wavelet input space), which is neither the coefficient space nor the measurement space; now returns phi.range_shape, matching the actual forward output shape.
  • DebiasOp imported verbose from tabnanny, which shadowed the verbose parameter; removed the import and added verbose: bool = False to the signature.

@cslht
cslht force-pushed the fix/operator-interface-errors branch from 8752c6c to 2cc2597 Compare August 6, 2026 09:24
@AnderBiguri

Copy link
Copy Markdown
Member

Thanks! I leave this unmerge for now because I am not sure if this is the way we will do operators. I'll get back to you soon on this.

@cslht

cslht commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Sure, no rush on my end. Just a heads-up: the two changes in here are unrelated. The DebiasOp fix is a plain bug — a stray from tabnanny import verbose shadowed the verbose parameter, so progress_bar=True crashes. Happy to split that one out if youd like it merged before the operator design is settled.

Also, since Ive had a few PRs merged (#194#202), could you add me to the README contributors list? An @all-contributors please add @cslht for code would do it. Thanks!

@allcontributors

Copy link
Copy Markdown
Contributor

@cslht

I've put up a pull request to add @cslht! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants