Fix operator interface errors in CompositeOp and DebiasOp - #203
Open
cslht wants to merge 1 commit into
Open
Conversation
cslht
force-pushed
the
fix/operator-interface-errors
branch
from
August 6, 2026 09:24
8752c6c to
2cc2597
Compare
Member
|
Thanks! I leave this unmerge for now because I am not sure if this is the way we will do operators. I'll get back to you soon on this. |
Contributor
Author
|
Sure, no rush on my end. Just a heads-up: the two changes in here are unrelated. The Also, since Ive had a few PRs merged (#194–#202), could you add me to the README contributors list? An |
Contributor
|
I've put up a pull request to add @cslht! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes in the operators:
CompositeOp.range_shapereturnedwavelet.domain_shape(the wavelet input space), which is neither the coefficient space nor the measurement space; now returnsphi.range_shape, matching the actual forward output shape.DebiasOpimportedverbosefromtabnanny, which shadowed theverboseparameter; removed the import and addedverbose: bool = Falseto the signature.