Fix validation and type-checking errors in optimizers - #201
Merged
AnderBiguri merged 1 commit intoAug 6, 2026
Conversation
cslht11
pushed a commit
to cslht11/LION
that referenced
this pull request
Sep 6, 2026
…on-errors Fix validation and type-checking errors in optimizers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four fixes in the optimizers:
EquivariantSolvercaptured loop variables by reference, so all four transforms were the samerotation_270; addedi=iso each transform stays distinct.GaussianDenoiserSolverpassed(y, outputs)(noisy input vs. denoised output) to the validation function; now(outputs, data)so validation matches the training objective.LIONsolver.check_training_readyhadisinstance(x, type)backwards, so wrong-typed attributes were never rejected; nownot isinstance(x, expected_type).LIONsolver.test()compared a GPU tensor with a numpy array; added.cpu().numpy()on the prediction.