Fix custom-geometry and on-the-fly reconstruction errors in deteCT - #200
Merged
Merged
Conversation
cslht11
pushed a commit
to cslht11/LION
that referenced
this pull request
Sep 6, 2026
…errors Fix custom-geometry and on-the-fly reconstruction errors in deteCT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes in
deteCT.pyfor custom geometry and on-the-fly reconstruction paths:np.array_equalcomparisons replaced 4 ambiguous comparisons (e.g.geometry_params == self.get_default_geometry()), which crashed withValueErroron custom geometry;np.array_equalhandles geometry objects correctly.next(angle_iterator)can returnNoneif the angle subset is exhausted; added a default so the reconstruction does not raise on an empty stream.deteCT.get_operator()called an instance method on the class in the reconstruction path; nowself.get_operator(), so it uses the current instance geometry.