Fix model construction errors - #199
Merged
AnderBiguri merged 1 commit intoAug 6, 2026
Merged
Conversation
cslht
changed the title
cslht11
pushed a commit
to cslht11/LION
that referenced
this pull request
Sep 6, 2026
…-crashes Fix model construction errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that let models be built from default parameters, without passing a parameter object:
dncnn.py: model built with the localmodel_parametersargument (None by default) instead of the parsed ones; now rebinds toself.model_parameters.drunet.py: same rebind, plus a stale local reference inside an f-string; now usesself.model_parameters.gs_drunet.py: importedDRUNetfrom a relative path that does not exist; now fromCNNs.ItNet.py/LG.py: inherited from nonexistentLIONmodel.LIONmodel; now fromLIONmodel.AR.py: read the undefinedself.geo; nowself.geometry.LIONmodel.py:NoDataExceptionwas referenced but never imported inset_normalisation; now imported.GaussianDenoiserSolver.py: called the non-callable numpy.size(0); now.shape[0].