Skip to content

Fix loading errors in ACR, AR and cFBPConvNet - #198

Merged
AnderBiguri merged 1 commit into
CambridgeCIA:mainfrom
cslht:fix/model-input-type-bugs
Aug 6, 2026
Merged

Fix loading errors in ACR, AR and cFBPConvNet#198
AnderBiguri merged 1 commit into
CambridgeCIA:mainfrom
cslht:fix/model-input-type-bugs

Conversation

@cslht

@cslht cslht commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Fix errors that prevented three models from loading or building their parameters.

  • ACR and AR imported ModelParams, which doesn't exist in LIONmodels (the class is LIONModelParameter), so both raised ImportError on import. Also, ACR.__init__ type-hinted ACRParams (undefined) and AR.__init__ used LIONParameter without importing it; both now use LIONModelParameter, matching the base class.
  • cFBPConvNet inherited from LIONmodel.LIONmodel (class used as a module) and raised AttributeError at class definition; now inherits from LIONmodel.
  • cFBPConvNet.default_parameters() did params = ModelInputType.IMAGE, overwriting the parameter object with an int and raising AttributeError on the next assignment; it should be params.model_input_type = ModelInputType.IMAGE.
  • ACR.default_parameters() set params.input_type, an attribute nothing reads, leaving model_input_type as None; now sets params.model_input_type.

@AnderBiguri
AnderBiguri merged commit b8be051 into CambridgeCIA:main Aug 6, 2026
1 check passed
cslht11 pushed a commit to cslht11/LION that referenced this pull request Sep 6, 2026
Fix loading errors in ACR, AR and cFBPConvNet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants