Fix loading errors in ACR, AR and cFBPConvNet - #198
Merged
Conversation
cslht11
pushed a commit
to cslht11/LION
that referenced
this pull request
Sep 6, 2026
Fix loading errors in ACR, AR and cFBPConvNet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix errors that prevented three models from loading or building their parameters.
ACRandARimportedModelParams, which doesn't exist inLIONmodels(the class isLIONModelParameter), so both raisedImportErroron import. Also,ACR.__init__type-hintedACRParams(undefined) andAR.__init__usedLIONParameterwithout importing it; both now useLIONModelParameter, matching the base class.cFBPConvNetinherited fromLIONmodel.LIONmodel(class used as a module) and raisedAttributeErrorat class definition; now inherits fromLIONmodel.cFBPConvNet.default_parameters()didparams = ModelInputType.IMAGE, overwriting the parameter object with an int and raisingAttributeErroron the next assignment; it should beparams.model_input_type = ModelInputType.IMAGE.ACR.default_parameters()setparams.input_type, an attribute nothing reads, leavingmodel_input_typeasNone; now setsparams.model_input_type.