Fix three small bugs in core utils - #195
Merged
Merged
Conversation
- normaliser: Normalisation('sample') crashed because torch max/min don't
accept a tuple dim; switched to amax/amin. The unnormalise(target) branch
also mixed a global max with per-sample min, now per-batch
- ct_geometry: bare 'staticmethod' (no @) never decorated the method, so
Geometry().parallel_sparse_angle_parameters() raised TypeError
- parameter: save() did fname.joinpath('.json') and dropped the result, so
suffix-less names saved without .json; now with_suffix('.json')
cslht
force-pushed
the
fix/ct-utils-small-issues
branch
from
August 5, 2026 02:23
947d09f to
dc55768
Compare
black --all-files in pre-commit flags LIONmodel.py and two classical_algorithms tests (from CambridgeCIA#194). Formatting only, no behavioural changes.
cslht11
pushed a commit
to cslht11/LION
that referenced
this pull request
Sep 6, 2026
Fix three small bugs in core utils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small fixes in core utils:
normaliser.py:Normalisation("sample")crashed — torchmax/mindon't take a tuple dim; switched toamax/amin(and the target branch to per-batch).ct_geometry.py: a barestaticmethod(no@) left the method un-decorated, so instance calls raisedTypeError; added the@.parameter.py:save()discarded thejoinpath('.json')result, so suffix-less names saved without.json; now useswith_suffix('.json').