Skip to content

fix: stop enums masking #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TimLeach635 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: stop enums masking #191

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de4e8ff
fix: stop enums masking
TimLeach635 Jul 1, 2026
523ce57
style: run black formatter
TimLeach635 Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions LION/models/LIONmodel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
# =============================================================================


#%% This is a base class for LION models.
# %% This is a base class for LION models.
#
# All classes must derive from this one.
# It definest a bunch of auxiliary functions
#

#%% Imports
# %% Imports

# You will want to import LIONParameter, as all models must save and use Parameters.
from enum import Enum
Expand Down Expand Up @@ -49,7 +49,7 @@
class ModelInputType(int, Enum):
SINOGRAM = 0
NOISY_RECON = 1
IMAGE = 1
IMAGE = 2


# Class for Model parameters that should be true for all models
Expand Down Expand Up @@ -83,8 +83,10 @@ def __init__(
f"Expected geometry to be of type Geometry or None, but got {type(geometry).__name__}. "
"If you passed positional arguments to the model, please verify their order matches the model's __init__ signature."
)

if model_parameters is not None and not isinstance(model_parameters, LIONModelParameter):

if model_parameters is not None and not isinstance(
model_parameters, LIONModelParameter
):
raise TypeError(
f"Expected model_parameters to be of type LIONModelParameter or None, but got {type(model_parameters).__name__}. "
"Ensure you are not accidentally passing a Geometry object as model_parameters."
Expand Down
Loading