Skip to content

fix(test): replace missing system-startup import with SystemOrchestration (#1120)#1194

Merged
joelteply merged 1 commit into
canaryfrom
fix/test-with-server-import-1120
May 14, 2026
Merged

fix(test): replace missing system-startup import with SystemOrchestration (#1120)#1194
joelteply merged 1 commit into
canaryfrom
fix/test-with-server-import-1120

Conversation

@joelteply
Copy link
Copy Markdown
Contributor

Symptom

From continuum#1120 (claude-tab-2 reproduction while validating PR #1085):

npm test -- --runTestsByPath src/tests/unit/seed-install-tier.test.ts

errors before any test runs because src/scripts/test-with-server.ts has:

import { startSystem } from './system-startup';

— and ./system-startup does not exist anywhere in the tree. Module resolution fails, the test runner never starts.

Fix

Swap the broken import for the canonical entry that already exists at src/system/core/SystemOrchestrator.ts:

import { SystemOrchestration } from '../system/core/SystemOrchestrator';

const result = await SystemOrchestration.forTesting();
if (!result.success) {
  throw new Error('System startup failed for npm-test mode');
}

SystemOrchestration.forTesting() is the exact factory the rest of the testing path uses — same options shape (mode: 'testing', persistent: true, captureOutput: 'logs', buildIfNeeded: true, timeout: 60000).

The previous call site lost its return value; restoring the loud-throw on failure means startup errors surface to the test runner instead of silently mis-behaving.

Validation

Closes #1120.

🤖 Generated with Claude Code

…tion (#1120)

Symptom from #1120 (claude-tab-2 reported, validating PR #1085):
  npm test -- --runTestsByPath src/tests/unit/seed-install-tier.test.ts
fails before any test runs because src/scripts/test-with-server.ts
imports a non-existent './system-startup' module.

The canonical entry for npm-test mode lives at
src/system/core/SystemOrchestrator.ts as
SystemOrchestration.forTesting() — same factory used by the rest of
the testing path. Update the import + replace startSystem('npm-test')
with the canonical call. Loud-throw on failure so test runs surface
startup errors rather than silently mis-behaving.

Validation: npm run build:ts passes clean. Hooks ran without --no-verify.

Card: continuum#1120.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@joelteply joelteply merged commit 5da3768 into canary May 14, 2026
4 checks passed
@joelteply joelteply deleted the fix/test-with-server-import-1120 branch May 14, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant