fix(test): replace missing system-startup import with SystemOrchestration (#1120)#1194
Merged
Merged
Conversation
…tion (#1120) Symptom from #1120 (claude-tab-2 reported, validating PR #1085): npm test -- --runTestsByPath src/tests/unit/seed-install-tier.test.ts fails before any test runs because src/scripts/test-with-server.ts imports a non-existent './system-startup' module. The canonical entry for npm-test mode lives at src/system/core/SystemOrchestrator.ts as SystemOrchestration.forTesting() — same factory used by the rest of the testing path. Update the import + replace startSystem('npm-test') with the canonical call. Loud-throw on failure so test runs surface startup errors rather than silently mis-behaving. Validation: npm run build:ts passes clean. Hooks ran without --no-verify. Card: continuum#1120. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
From continuum#1120 (claude-tab-2 reproduction while validating PR #1085):
errors before any test runs because
src/scripts/test-with-server.tshas:— and
./system-startupdoes not exist anywhere in the tree. Module resolution fails, the test runner never starts.Fix
Swap the broken import for the canonical entry that already exists at
src/system/core/SystemOrchestrator.ts:SystemOrchestration.forTesting()is the exact factory the rest of the testing path uses — same options shape (mode: 'testing',persistent: true,captureOutput: 'logs',buildIfNeeded: true,timeout: 60000).The previous call site lost its return value; restoring the loud-throw on failure means startup errors surface to the test runner instead of silently mis-behaving.
Validation
npm run build:tspasses clean (no other consumers of the deadsystem-startupmodule).--no-verify.branch-name == workrule); split out offix/precommit-config-loader(PR fix(precommit): add scripts/precommit-config.sh the hook expects (#1190) #1193) where it accidentally landed first.Closes #1120.
🤖 Generated with Claude Code