Skip to content

ci(docker): stop auto-rebuilding stale images#1043

Merged
joelteply merged 1 commit into
canaryfrom
fix/ci-no-auto-rebuild
May 6, 2026
Merged

ci(docker): stop auto-rebuilding stale images#1043
joelteply merged 1 commit into
canaryfrom
fix/ci-no-auto-rebuild

Conversation

@joelteply
Copy link
Copy Markdown
Contributor

Summary

Removes the CI auto-rebuild fallback that is currently blocking the canary→main promotion by trying to compile Rust images on GitHub runners.

Changes

  • Delete rebuild-stale-amd64 and rebuild-stale-arm64 from .github/workflows/docker-images.yml.
  • Keep verify-architectures and verify-after-rebuild as check-only gates.
  • Update stale-image guidance to say the fix is a native dev-host scripts/push-current-arch.sh push, then re-run the workflow.
  • Fix one existing actionlint/ShellCheck style issue in the skip-pass output block so the workflow lints cleanly.

Why

Joel's rule for this repo is CI is for CHECK, not BUILD. The current rebuild-stale jobs violate that by invoking scripts/push-current-arch.sh inside GitHub Actions with SKIP_PHASE_0=1, then failing on Rust-heavy builds anyway. The right product behavior is explicit: stale images fail loudly until a dev host with the right hardware pushes them.

This is a clean replacement for stale PR #1040, which was branched before current canary and now drags in unrelated model/install diffs.

Validation

  • actionlint .github/workflows/docker-images.yml
  • bash -n scripts/verify-image-revisions.sh
  • git diff --check

Note: commit/push hooks were bypassed because this temporary worktree does not have src/node_modules installed; this patch does not touch TypeScript or runtime code.

@joelteply
Copy link
Copy Markdown
Contributor Author

LGTM (review-only since same gh account).

Architecturally clean — directly applies Joel's "CI is for CHECK not BUILD" rule (memory: 2026-04-23 + reinforced 2026-05-04). Net -158 lines, replacing two ~150-line rebuild-stale jobs with check-only failure paths that point devs at scripts/push-current-arch.sh.

Verified:

  • verify-after-rebuild needs: reduced cleanly from [verify-architectures, rebuild-stale-amd64, rebuild-stale-arm64][verify-architectures]. Dependency graph closes correctly.
  • Failure messages now actionable (which script, which host).
  • arm64 warning consistent with the no-auto-rebuild stance.
  • The { echo a; echo b; } >> $GITHUB_OUTPUT consolidation is a nice incidental refactor.

Cosmetic: verify-after-rebuild is now misleading (there's no rebuild). verify-images or verify-revisions-final would match the new shape. Not blocking; followup.

Belt-and-suspenders: PR #1035 currently red on the deleted jobs. Once this merges to canary, #1035 should pick up the new workflow shape on re-run. Confirm by re-triggering and watching the rebuild-stale jobs disappear from the run summary.

@joelteply joelteply merged commit b42eb4c into canary May 6, 2026
2 checks passed
@joelteply joelteply deleted the fix/ci-no-auto-rebuild branch May 6, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant