Skip to content

Resolves #1730, Fix database inconsistency with account cleanup#1824

Merged
david-rocca merged 4 commits into
devfrom
af-1730
May 27, 2026
Merged

Resolves #1730, Fix database inconsistency with account cleanup#1824
david-rocca merged 4 commits into
devfrom
af-1730

Conversation

@afoote-mitre
Copy link
Copy Markdown
Collaborator

Closes Issue #1730

Summary

If the user exists in at least one of the schemas, the administrator must be allowed to modify, deactivate, or rotate secrets on whatever records do exist, rather than throwing an unhandled exception

Important Changes

src/repositories/baseUserRepository.js

  • Updated updateUser(), updateUserFull(), and resetSecret() to handle cases where a user exists in at least one but not necessarily both schemas.

Testing

Steps to manually test updated functionality, if possible

  • 1) Run npm run test:integration and ensure all tests pass
  • 2) Run npm run test:unit-tests and ensure all tests pass
  • 3) Ensure test case outlined in original ticket succeeds as expected

@afoote-mitre afoote-mitre requested a review from david-rocca May 22, 2026 16:23
@afoote-mitre afoote-mitre self-assigned this May 22, 2026
@david-rocca david-rocca merged commit a352827 into dev May 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants