Skip to content

Resolves issue #1819: Return object for GET requests of non existent reviews#1820

Merged
david-rocca merged 5 commits into
devfrom
af-1819
May 21, 2026
Merged

Resolves issue #1819: Return object for GET requests of non existent reviews#1820
david-rocca merged 5 commits into
devfrom
af-1819

Conversation

@afoote-mitre
Copy link
Copy Markdown
Collaborator

@afoote-mitre afoote-mitre commented May 21, 2026

Closes Issue #1819

Summary

GET requests for non existent reviews will now return a 200 with pendingReview set to null, instead of the previous behavior where it 404s.

Important Changes

src/controller/review-object.controller/review-object.controller.js

  • Updated response provided by the getReviewObjectByOrgIdentifier() function

src/test/integration-tests/review-object/reviewObjectTest.js

  • Updated integration test to now expect the updated response from the GET review call

src/test/unit-tests/review-object/review-object.controller.test.js

  • Updated unit tests to now expect the updated response from the GET review call

Testing

Steps to manually test updated functionality, if possible

  • 1) Run npm run test:integration and ensure all tests pass
  • 2) Run npm run test:unit-tests and ensure all tests pass

@afoote-mitre afoote-mitre requested a review from david-rocca May 21, 2026 15:49
@afoote-mitre afoote-mitre self-assigned this May 21, 2026
@david-rocca david-rocca merged commit 8aa91b3 into dev May 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants