Refactor (script/upgrade-opentui.ts): Function with many returns - #48
Open
NancyAanchal wants to merge 2 commits into
Open
Refactor (script/upgrade-opentui.ts): Function with many returns#48NancyAanchal wants to merge 2 commits into
NancyAanchal wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #33
Type of change
What does this PR do?
->Qlty flagged setVersion in script/upgrade-opentui.ts for "many returns," 7 return statements. Collapsed the 7 returns into a single lookup/array + .find() pattern that picks a prefix, then one final return. Moreover, the function was using some global variables, changed it to accomodate those in the parameters. Also made the function exportable for tests.
Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR.
If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!
How did you verify your code works?
-Ran qlty smells --no-snippets script/upgrade-opentui.ts before and after — "many returns" smell disappeared, file complexity dropped from 63 to 55
-Wrote script/upgrade-opentui.test.ts with 8 tests covering every branch of setVersion
-Ran bun test upgrade-opentui.test.ts from script/ and all 8 pass
-Ran coverage and setVersion itself fully exercised; only uncovered lines are the untouched CLI logic
-Added a CI step in test.yml so these tests actually run on this PR
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.