Refactor/dialog export options many params - #35
Open
noorkcmu wants to merge 3 commits into
Open
Conversation
noorkcmu
force-pushed
the
refactor/dialog-export-options-many-params
branch
from
September 2, 2026 16:08
5c4d797 to
ea32fe0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28
Type of change
What does this PR do?
Qlty flagged DialogExportOptions.show for having too many parameters (6). This PR groups the 5 default values into one object parameter, so the function is easier to call and less likely to have arguments mixed up by accident. Also updated the one place that calls it.
Also added a small fix to turbo.json so the new tests actually run in CI — they weren't wired up before.
How did you verify your code works?
I added 2 new tests that call DialogExportOptions.show, one for confirming and one for cancelling the dialog. I ran typecheck, lint, and the full test suite and everything passes. I also ran Qlty again on the file to confirm the flagged issue is gone and nothing new showed up.
Screenshots / recordings
Checklist