chore(deps): update repo tooling to jest 30, pnpm 12, and async-storage 3 - #191
Merged
Conversation
…ge 3 Takes the non-blocked half of #189. Babel 8 and TypeScript 7 are held back by upstream and pinned in the Renovate config rather than carried here. - rename AsyncStorage `multiRemove` to v3's `removeMany`, and point the jest setup at the mock's new `/jest` entry point - wrap the shipped AsyncStorage mock in jest spies: v3 ships plain functions, and tests assert on the calls - clear the mock through the instance, not `clearAllMockStorages()`, which empties the registry and leaves the handed-out instance holding its data - type the test mocks that jest 30 now checks against their real signatures - restore node types to the app tsconfig, dropped when @types/jest stopped pulling them in - decide the two build scripts pnpm 12 asks about, both declined - exclude the lockfile from check-yaml: pnpm 12 writes it as two documents - hold @babel/core and typescript below the versions their toolchains reject
Reviewed the hand-maintained dependency policy against the resolved tree. - correct the shell-quote advisory id, which had been mangled to `GHSA-wpn peer7jw-789q-3m8p`, to GHSA-w7jw-789q-3m8p - drop the two image-size advisories from ignoreGhsas and from ci.yml's allow-ghsas: the package is no longer in the tree, so both entries were waiving nothing. `just audit` now reports 1 ignored finding, not 3 - drop the dompurify@3.4.13 release-age exclusion, superseded by the override pinning 3.4.14 - restate why lightningcss is pinned: the NativeWind reason is gone with the Uniwind migration, but removing it resolves three copies side by side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes the part of #189 that actually works, and pins the parts that don't so Renovate stops proposing them.
Landed
@types/jest30 +@jest/globals30toHaveBeenCalledWithtyping found several test mocks whose declared signature did not match the real function@react-native-async-storage/async-storage3multiRemove→removeMany; jest mock moved to the/jestentry pointHeld back, with Renovate rules
TypeScript 7 breaks
astro checkindocs/andwww/:Gated as
allowedVersions: "!/^7\.0\./"rather than<7, so 7.1 still arrives as a PR and docs/www typecheck answers whether the API is back. The TS team calls this point-in-time but has named no version (withastro/roadmap#1321).Babel 8 is rejected outright by
react-native-worklets' babel plugin, which hard-requires^7.0.0-0. Every app suite touching a worklet failed to transform (221/221 suites red). Gated at<8until the Expo/RN toolchain moves.Deferred
@testing-library/react-native14 maderenderandrenderHookasync — 489 call sites across 90 files needawait. It alone accounted for 418 of the 480 initial type errors. It deserves its own branch where a missedawaitis attributable.Also in here
A review of the hand-maintained dependency policy against the resolved tree:
GHSA-wpn peer7jw-789q-3m8p; the real one isGHSA-w7jw-789q-3m8p(range>=1.1.0, <=1.8.3, matching the override key)image-sizeis no longer in the tree, so its two GHSAs were waiving nothing in bothpnpm-workspace.yamlandci.yml.just auditnow reports 1 ignored finding instead of 3dompurify@3.4.13release-age exclusion was superseded by the override pinning 3.4.14lightningcsspin cites NativeWind, which the Uniwind migration removed — but it still earns its place: without it the tree resolves 1.30.1, 1.32.0 and 1.33.0 side by side. Comment corrected, pin keptcheck-yamlnow skipspnpm-lock.yaml, which pnpm 12 writes as two documentsVerified locally
just check,just pre-commit,just audit— passjust test— pass (root 43 + 105 policy checks, backend 1812, www 11, docs 161, app 1818 — same app count as main)test:links— pass