The node-alias scan compares forward-slash paths, so its own file is not "foreign" on Windows - #540
Merged
Merged
Conversation
…not "foreign" on Windows
`the_node_alias_literal_exists_exactly_once_in_the_tree` exempts this
file by `starts_with("src/key_convention.rs")`, and on Windows the
scanned path renders as `src\key_convention.rs` — so the file's own two
sites counted as foreign and the assertion fired. main's `clippy + test
(windows-latest)` has been red on every run since the test landed in
e46c45f (0.5.196), and the PR lane is ubuntu-only, so no PR ever saw it.
The #517 class: a path bug in the gate itself. Paths are normalised to
forward slashes before the exemption is applied.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QVZ3v83uX8noLxXr7d7pu9
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main's
clippy + test (windows-latest)has been red on every run since e46c45f (0.5.196, 2026-08-30) — the commit that addedkey_convention::tests::the_node_alias_literal_exists_exactly_once_in_the_tree. The test exempts its own file bystarts_with("src/key_convention.rs"); on Windowspath.display()yieldssrc\key_convention.rs, so the file's own two sites read as foreign and the assertion fired:Ubuntu and macOS pass, and the PR lane is ubuntu-only, so nothing ever surfaced this before a merge. Same class as #517: a path bug in the gate itself.
Change: the scanned path is normalised to forward slashes before the exemption is applied. Behaviour on Linux/macOS is unchanged (7/7
key_conventiontests pass locally).Labelled
ci:fullso the Windows and macOS lanes run on this PR rather than after the merge. Becausecargo teststops at the first failing binary, the Windows lane has not run the integration tests since 2026-08-30 — anything else Windows-only will surface on this run.🤖 Generated with Claude Code
https://claude.ai/code/session_01QVZ3v83uX8noLxXr7d7pu9