Skip to content

Move SQLToolService logs to debug level #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emooreatx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move SQLToolService logs to debug level #596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions ciris_adapters/external_data_sql/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,7 @@ async def initialize(self) -> None:
# Note: BaseService doesn't have initialize(), but this is required by framework
# await super().initialize() # Skip if not implemented

# TODO: Move to debug level after tool registration is confirmed working
self._logger.info(
self._logger.debug(
f"SQLToolService initializing with config: {self._config.connector_id if self._config else 'None'}"
)
self._logger.info(f"SQLToolService has {len(self._tool_schemas)} tool schemas ready")
Expand Down Expand Up @@ -155,8 +154,7 @@ async def initialize(self) -> None:
# Connect to database
await self._connect()

# TODO: Move to debug level after tool registration is confirmed working
self._logger.info(f"SQLToolService initialized successfully - tools: {await self.list_tools()}")
self._logger.debug(f"SQLToolService initialized successfully - tools: {await self.list_tools()}")

async def _connect(self) -> None:
"""Establish database connection."""
Expand Down Expand Up @@ -218,8 +216,7 @@ async def list_tools(self) -> List[str]:
Returns:
List of generic SQL tool names
"""
# TODO: Move to debug level after tool registration is confirmed working
self._logger.info(f"list_tools() called on SQLToolService")
self._logger.debug(f"list_tools() called on SQLToolService")
tools = [
"initialize_sql_connector",
"get_sql_service_metadata",
Expand All @@ -231,8 +228,7 @@ async def list_tools(self) -> List[str]:
"sql_get_stats",
"sql_query",
]
# TODO: Move to debug level after tool registration is confirmed working
self._logger.info(f"list_tools() returning {len(tools)} tools: {tools}")
self._logger.debug(f"list_tools() returning {len(tools)} tools: {tools}")
return tools

async def execute_tool(self, tool_name: str, parameters: JSONDict) -> ToolExecutionResult:
Expand All @@ -245,8 +241,7 @@ async def execute_tool(self, tool_name: str, parameters: JSONDict) -> ToolExecut
Returns:
Tool execution result
"""
# TODO: Move to debug level after tool registration is confirmed working
self._logger.info(f"execute_tool() called with tool_name={tool_name}, parameters={list(parameters.keys())}")
self._logger.debug(f"execute_tool() called with tool_name={tool_name}, parameters={list(parameters.keys())}")

# Extract or generate correlation ID for result tracking
import uuid
Expand Down Expand Up @@ -351,8 +346,7 @@ async def _initialize_connector(self, parameters: JSONDict) -> ToolExecutionResu
Returns:
ToolExecutionResult with connector configuration details
"""
# TODO: Move to debug level after tool registration is confirmed working
self._logger.info(f"_initialize_connector called with parameters: {list(parameters.keys())}")
self._logger.debug(f"_initialize_connector called with parameters: {list(parameters.keys())}")

# Extract or generate correlation ID
import uuid
Expand Down Expand Up @@ -494,8 +488,7 @@ async def _get_sql_metadata(self, parameters: JSONDict) -> ToolExecutionResult:
Returns:
ToolExecutionResult with connector metadata
"""
# TODO: Move to debug level after tool registration is confirmed working
self._logger.info(f"_get_sql_metadata called with parameters: {list(parameters.keys())}")
self._logger.debug(f"_get_sql_metadata called with parameters: {list(parameters.keys())}")

# Extract or generate correlation ID
import uuid
Expand Down
Loading