ci(windows): capture UI state per step — screenshot plus element tree - #1053
Open
emooreatx wants to merge 1 commit into
Open
ci(windows): capture UI state per step — screenshot plus element tree#1053emooreatx wants to merge 1 commit into
emooreatx wants to merge 1 commit into
Conversation
The Windows failures ahead are UI-state problems, and a log line will not explain them. The desktop test server already exposed GET /screenshot; the Python helper never used it. capture_step() takes BOTH a PNG and the element tree, because they fail in opposite conditions. The PNG comes from AWT Robot.createScreenCapture, which grabs the SCREEN rather than rendering the window, so it needs a real display — on a runner with no interactive desktop session it will throw or return a black frame. The tree is plain text, needs no display, and is greppable and diffable: for 'which step did the UI stop matching what we expected', diffing a passing run against a failing one beats a picture. It NEVER raises. A troubleshooting aid that can fail the test it was meant to explain is worse than none — the first Windows run died inside the harness, and a capture helper with its own failure mode would have buried the cause. The workflow collects ui_captures/ and lists what it got, so a missing PNG is visible as an expected gap rather than a silent one.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows failures ahead are UI-state problems, and a log line won't explain them.
The desktop test server already exposed
GET /screenshot— the Python helper never used it.capture_step()takes both a PNG and the element tree, because they fail in opposite conditions:Robot.createScreenCapture, which grabs the screen rather than rendering the window. It needs a real display, so on a runner with no interactive desktop session it will throw or return a black frame. Excellent locally, possibly worthless in CI.It never raises. A troubleshooting aid that can fail the test it was meant to explain is worse than none — the first Windows run died inside the harness, and a capture helper with its own failure mode would have buried the cause.
The workflow collects
ui_captures/and lists what it got, so a missing PNG shows up as an expected gap rather than a silent one.