fix(harvester): parse numeric INSPIRE id from combined log prefixes#867
Open
TahaKhan998 wants to merge 1 commit into
Open
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #861
Solves no.6 of https://codimd.web.cern.ch/s/DBWeY3d5y
Harvester report links broke when log lines used a combined prefix like [INSPIRE#1642662 CDS#c42kw-9f710], because the parser took everything after INSPIRE# until ] as the record id. This keeps that useful combined prefix in the logs, but extracts only the numeric INSPIRE id for links and strips the full bracketed prefix when building grouping titles.