feat(assets): Switch to pnpm and rspack#832
Conversation
| executeSearch(defaultRun, ""); | ||
| } | ||
| }, []); | ||
| }, [currentQueryState, runs, defaultRun]); |
There was a problem hiding this comment.
could you check this warning?
| @@ -0,0 +1 @@ | |||
| lockfile=false No newline at end of file | |||
There was a problem hiding this comment.
Disable package-lock.json
| @@ -0,0 +1,12382 @@ | |||
| lockfileVersion: '9.0' | |||
There was a problem hiding this comment.
this is quite sensitive change. If I remember correctly package-lock.json is used to build our deployment images - did you adapt that to the change, will the image still build correctly?
There was a problem hiding this comment.
Yes, this is also how Zenodo and other instances are doing it as well.
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "name": "cds-rdm-site", | |||
There was a problem hiding this comment.
why do we need to add package.json here?
There was a problem hiding this comment.
I am also confused about this, it would maybe make sense if it was included as a workspace in the root level package.json and all of the dependencies were instead listed here. But I'm not sure why it's necessary in the current form.
There was a problem hiding this comment.
It is to fix the broken linter, purpose mentioned in the description already. For the dependencies for eslint.
| - name: Use Node.js v20.x | ||
| uses: actions/setup-node@v6 | ||
| - name: Install pnpm | ||
| uses: pnpm/action-setup@v4 |
There was a problem hiding this comment.
Any reason why we are not using v6 of the pnpm action?
There was a problem hiding this comment.
No reason 👀
I will update
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "name": "cds-rdm-site", | |||
There was a problem hiding this comment.
I am also confused about this, it would maybe make sense if it was included as a workspace in the root level package.json and all of the dependencies were instead listed here. But I'm not sure why it's necessary in the current form.
| COPY package-lock.json ${INVENIO_INSTANCE_PATH}/assets/ | ||
| COPY ./assets/ ${INVENIO_INSTANCE_PATH}/assets/ | ||
| COPY ./static/ ${INVENIO_INSTANCE_PATH}/static/ | ||
| RUN cd ${INVENIO_INSTANCE_PATH}/assets && pnpm run build |
There was a problem hiding this comment.
could you keep it the way it was? that we copy the file from the repo to instance assets and we use that to install later?
3 participants
No description provided.