fix(python/geometry): Prevent cast_to_single from casting integers to float32 (#678)#750
Merged
Merged
Conversation
Member
|
ah thanks! I assume this is one of those numpy 2.4 caused issues, which is why I didn't catch it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #678 where
Geometry.cast_to_single()forcefully cast integers and lists of integers intonp.float32, which inadvertently corrupts integer-based attributes and crashes memory allocations in algorithms likesart.Changes made
np.issubdtypeto gracefully intercept and ignore pure integers and arrays of integers.exclude_from_casthardcoded array, preventing this issue from occurring on any custom integer variables users might attach to theGeometryobject.