Skip to content

CI: Add datafile for consistency with other MCRs#728

Merged
CodeGat merged 1 commit into
mainfrom
ci-add-datafile
Jun 18, 2026
Merged

CI: Add datafile for consistency with other MCRs#728
CodeGat merged 1 commit into
mainfrom
ci-add-datafile

Conversation

@CodeGat

@CodeGat CodeGat commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Background

Currently, CABLE is the only Model Component Repository that doesn't use build-cis inputs.spack-manifest-data-path input. It's not required by MCRs, but for an update to the CI in access-spack-packages (see ACCESS-NRI/access-spack-packages#420) which tests manifests defined in model component repositories, it would be much simpler if this repository had one.

If there are changes to the manifests in the future, more common data can be added to this file, as well!

The PR

  • Added .github/build-ci/data/standard.json, a file that defines key-value pairs that are usable in .github/build-ci/manifests/*.spack.yaml.j2 files. Currently, only one target: x86_64 is defined.
  • Replaced x86_64 with {{ target }} in the manifest, which will be replaced at spack install time
  • Added inputs.spack-manifest-data-path to the build-ci workflow call

📚 Documentation preview 📚: https://cable--728.org.readthedocs.build/en/728/

@CodeGat CodeGat self-assigned this Jun 18, 2026
@CodeGat CodeGat requested a review from Whyborn June 18, 2026 04:54
@Whyborn

Whyborn commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Can the entries in standards.json take multiple entries for different build configurations?

@CodeGat

CodeGat commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Either by naming them differently in the same datafile, or via different datafiles themselves, sure!

@Whyborn Whyborn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@CodeGat CodeGat merged commit 1aa7aeb into main Jun 18, 2026
5 checks passed
@CodeGat CodeGat deleted the ci-add-datafile branch June 18, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants