Skip to content

Add option to use infilled CORINE#447

Merged
stelliom merged 5 commits into
masterfrom
infill-corine
Apr 24, 2026
Merged

Add option to use infilled CORINE#447
stelliom merged 5 commits into
masterfrom
infill-corine

Conversation

@stelliom
Copy link
Copy Markdown
Contributor

@stelliom stelliom commented Apr 23, 2026

Description

This PR adds an option (i.e., infill_corine) to the Python wrapper to let Zonda users select between the normal CORINE dataset and the new CORINE dataset with infilled voids (using GlobCover data).

Workflow for merging PRs

Please read these instructions carefully and follow the steps below before requesting a review by the maintainers. This way we can ensure a smoother review process and your changes will be merged sooner.

Additionally, if this is the first PR you open in EXTPAR make sure to read the "Information for EXTPAR Developers" section in the documentation.

Checklist

  • Provide a detailed description of your changes in the "Description" section above.
  • If you implemented a new feature:
    • Document it in the correct Markdown file(s) under the docs/ directory.
    • Add a new test or make sure your changes are already tested.
  • Your code follows the style guidelines.
  • Your changes only touch the files/lines relevant for you.
  • All four required checks pass (see "Testing and debugging" for more details).
  • No conflicts with the base branch.

If all the points above are satisfied you can ask for a review by selecting stelliom as a reviewer.

For any questions please ping @stelliom on this PR.

Testing and debugging

The most important test for PRs is the one labeled "EXTPAR Testsuite on Jenkins". This checks that the results of all testcases (described by the namelists in test/testsuite/data) did not change compared to the references.

You can launch the testsuite by writing launch jenkins as a comment in the PR that you want to test. Once completed, the result of the testsuite will be shown on the PR (failure or success).

If you need more details on the testsuite results (e.g., if you are trying to debug an error or you are simply unsure why the tests fail) you can launch the testsuite with launch jenkins(debug). This will run the tests as usual, but, once completed, you will be given a URL (via a comment on the PR) to access the logfiles and namelists of all tests that were run.

@stelliom stelliom changed the title Infill corine Add option to use infilled CORINE Apr 23, 2026
@stelliom
Copy link
Copy Markdown
Contributor Author

launch jenkins(debug)

@jenkins-apn
Copy link
Copy Markdown

The testsuite you launched for this PR has failed. You can inspect the results at this link.

@stelliom
Copy link
Copy Markdown
Contributor Author

stelliom commented Apr 23, 2026

Still need to create new references for the testsuite since GlobCover and CORINE were updated.

@stelliom
Copy link
Copy Markdown
Contributor Author

launch jenkins

@stelliom stelliom enabled auto-merge (squash) April 24, 2026 16:23
@stelliom stelliom merged commit 06cf879 into master Apr 24, 2026
4 checks passed
@stelliom stelliom deleted the infill-corine branch April 28, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants