Skip to content

ci(pr-validation): replace deprecated changelog gate with commit-lint #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
williaby wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci(pr-validation): replace deprecated changelog gate with commit-lint #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/pr-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,17 @@

jobs:
# ==========================================================================
# Supplemental PR Checks (Changelog, Link Validation)
# Supplemental PR Checks (Commit Lint, Link Validation)
# ==========================================================================
supplemental-checks:
uses: ByronWilliamsCPA/.github/.github/workflows/python-supplemental-checks.yml@987d517d3c8e4b180f4dd15de6d9575f0df91182 # main
with:
# Changelog enforcement
enable-changelog-check: true
changelog-path: 'CHANGELOG.md'
changelog-skip-labels: 'skip-changelog,dependencies,documentation'
# Conventional-Commit PR-title validation. Replaces the deprecated
# enable-changelog-check gate (ByronWilliamsCPA/.github#288): the changelog
# is generated at release by python-semantic-release (see release.yml), so
# per-PR CHANGELOG.md edits are no longer required and were the sole cause
# of textual conflicts in the org merge queue.
enable-commit-lint: true

# Documentation link validation
enable-link-check: true
Expand Down Expand Up @@ -72,12 +74,12 @@
run: uv python install 3.12

- name: Install dependencies
run: uv sync --all-extras

Check warning on line 77 in .github/workflows/pr-validation.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Omitting "--no-build" can lead to the execution of setup scripts. Make sure it is safe here. 


See more on https://sonarcloud.io/project/issues?id=ByronWilliamsCPA_python-libs&issues=AaBtDyUuznKcUKZOFqBZ&open=AaBtDyUuznKcUKZOFqBZ&pullRequest=60

Check warning on line 77 in .github/workflows/pr-validation.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Using dependencies without locking resolved versions is security-sensitive. 


See more on https://sonarcloud.io/project/issues?id=ByronWilliamsCPA_python-libs&issues=AaBtDyUuznKcUKZOFqBa&open=AaBtDyUuznKcUKZOFqBa&pullRequest=60

- name: Run vulture
run: |
echo "## Dead Code Report" >> $GITHUB_STEP_SUMMARY
uv run vulture src/ packages/ --min-confidence 90 | tee vulture-report.txt || true

Check warning on line 82 in .github/workflows/pr-validation.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Omitting "--no-build" can lead to the execution of setup scripts. Make sure it is safe here. 


See more on https://sonarcloud.io/project/issues?id=ByronWilliamsCPA_python-libs&issues=AaBtDyUuznKcUKZOFqBb&open=AaBtDyUuznKcUKZOFqBb&pullRequest=60

Check warning on line 82 in .github/workflows/pr-validation.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Using dependencies without locking resolved versions is security-sensitive. 


See more on https://sonarcloud.io/project/issues?id=ByronWilliamsCPA_python-libs&issues=AaBtDyUuznKcUKZOFqBc&open=AaBtDyUuznKcUKZOFqBc&pullRequest=60
if [ -s vulture-report.txt ]; then
echo '```' >> $GITHUB_STEP_SUMMARY
cat vulture-report.txt >> $GITHUB_STEP_SUMMARY
Expand Down
Loading