Next 4.1.0

build-scripts/check-coverage-thresholds.js

@@ -13,6 +13,9 @@ const summary = JSON.parse(fs.readFileSync(summaryPath, 'utf8'));
 const thresholds = {
   'src/main/main.ts': { lines: 12, statements: 12 },
   'src/main/preload.ts': { lines: 80, statements: 80 },
+  'src/main/processKill.ts': { lines: 80, statements: 80 },
+  'src/utils/validation.ts': { lines: 85, statements: 85 },
+  'src/utils/downloadLifecycle.ts': { lines: 90, statements: 90 },
 };
 
 function findCoverageEntry(suffix) {
@@ -46,4 +49,4 @@ if (failures.length > 0) {
   process.exit(1);
 }
 
-console.log('Coverage thresholds passed for main.ts and preload.ts.');
+console.log('Coverage thresholds passed.');

build-scripts/test-all.js

@@ -16,6 +16,7 @@ const colors = {
 
 const results = {
   unit: { status: 'pending', passed: 0, failed: 0 },
+  compile: { status: 'pending' },
   lint: { status: 'pending' },
   format: { status: 'pending' },
   typecheck: { status: 'pending' },
@@ -152,6 +153,10 @@ function runConfigChecks() {
       'package.json: scripts.test:all must run build-scripts/test-all.js'
     );
     assertConfig(pkg.main === 'dist/main/main.js', 'package.json: main must be dist/main/main.js');
+    assertConfig(
+      pkg.desktopName === 'com.burnttoasters.rosi.desktop',
+      'package.json: desktopName must be com.burnttoasters.rosi.desktop'
+    );
     assertConfig(
       Boolean(pkg.scripts && pkg.scripts['ffmpeg:check']),
       'package.json: missing scripts.ffmpeg:check'
@@ -186,6 +191,10 @@ function runConfigChecks() {
       Array.isArray(baseConfig.linux?.extraResources),
       'electron-builder.base.yml: linux.extraResources missing for yt-dlp binaries'
     );
+    assertConfig(
+      baseConfig.linux?.syncDesktopName === true,
+      'electron-builder.base.yml: linux.syncDesktopName must be true'
+    );
     assertConfig(
       Boolean(githubConfig.publish),
       'electron-builder.github.yml: missing publish config'
@@ -209,6 +218,7 @@ function runConfigChecks() {
       'build/app-icon.icns',
       'build/app-icon.png',
       'build/appx/appxmanifest.xml',
+      'com.burnttoasters.rosi.desktop',
     ];
     for (const relativePath of requiredFiles) {
       assertConfig(
@@ -234,6 +244,9 @@ function run() {
   const unitResult = runCommand('unit', 'npm test', parseUnitTests);
   results.unit.status = unitResult.ok ? 'passed' : 'failed';
 
+  const compileResult = runCommand('compile', 'npm run compile');
+  results.compile.status = compileResult.ok ? 'passed' : 'failed';
+
   const lintResult = runCommand('lint', 'npm run lint');
   results.lint.status = lintResult.ok ? 'passed' : 'failed';
 
@@ -250,6 +263,7 @@ function run() {
 
   const summaryLines = [
     `${colors.bold}Unit:${colors.reset}      ${results.unit.status === 'passed' ? colors.green + '✓ PASS' : colors.red + '✗ FAIL'}${colors.reset} (${results.unit.passed} passed${results.unit.failed > 0 ? `, ${results.unit.failed} failed` : ''})`,
+    `${colors.bold}Compile:${colors.reset}   ${results.compile.status === 'passed' ? colors.green + '✓ PASS' : colors.red + '✗ FAIL'}${colors.reset}`,
     `${colors.bold}Lint:${colors.reset}      ${results.lint.status === 'passed' ? colors.green + '✓ PASS' : colors.red + '✗ FAIL'}${colors.reset}`,
     `${colors.bold}Format:${colors.reset}    ${results.format.status === 'passed' ? colors.green + '✓ PASS' : colors.red + '✗ FAIL'}${colors.reset}`,
     `${colors.bold}Typecheck:${colors.reset} ${results.typecheck.status === 'passed' ? colors.green + '✓ PASS' : colors.red + '✗ FAIL'}${colors.reset}`,
@@ -289,4 +303,11 @@ if (require.main === module) {
   run();
 }
 
-module.exports = { runCommand, runSyntaxChecks, runConfigChecks };
+module.exports = {
+  runCommand,
+  runSyntaxChecks,
+  runConfigChecks,
+  stripAnsi,
+  parseUnitTests,
+  results,
+};

com.burnttoasters.rosi.desktop

@@ -6,5 +6,5 @@ Icon=com.burnttoasters.rosi
 Type=Application
 Categories=Utility;AudioVideo;Network;
 StartupNotify=true
-StartupWMClass=Rosi
+StartupWMClass=com.burnttoasters.rosi
 Keywords=video;download;yt-dlp;youtube;converter;ffmpeg;

electron-builder.base.yml

@@ -66,6 +66,7 @@ linux:
     - rpm
   icon: build/app-icon.png
   category: Utility
+  syncDesktopName: true
   extraResources:
     - from: assets/
       to: assets/

package.json

@@ -3,6 +3,7 @@
   "version": "4.1.0-beta.2",
   "private": true,
   "description": "Electron GUI for yt-dlp",
+  "desktopName": "com.burnttoasters.rosi.desktop",
   "keywords": [
     "electron",
     "yt-dlp",

src/tests/buildScripts.gitPrune.test.ts

@@ -0,0 +1,37 @@
+import { describe, expect, it } from 'vitest';
+
+const {
+  parseArgs,
+  selectBranchesToDelete,
+  stripRemotePrefix,
+} = require('../../build-scripts/git-prune-local-branches.js');
+
+describe('git-prune-local-branches helpers', () => {
+  it('parseArgs reads remote, dry-run, and force flags', () => {
+    expect(parseArgs(['node', 'script.js'])).toEqual({
+      remote: 'origin',
+      dryRun: false,
+      force: false,
+    });
+    expect(parseArgs(['node', 'script.js', '--remote', 'upstream', '-n', '--force'])).toEqual({
+      remote: 'upstream',
+      dryRun: true,
+      force: true,
+    });
+  });
+
+  it('stripRemotePrefix removes the remote prefix', () => {
+    expect(stripRemotePrefix('origin/main', 'origin')).toBe('main');
+    expect(stripRemotePrefix('origin/HEAD', 'origin')).toBeNull();
+    expect(stripRemotePrefix('main', 'origin')).toBeNull();
+  });
+
+  it('selectBranchesToDelete keeps current and remote-tracking branches', () => {
+    const result = selectBranchesToDelete(
+      ['main', 'feature/a', 'feature/b'],
+      ['main', 'feature/a'],
+      'main'
+    );
+    expect(result).toEqual(['feature/b']);
+  });
+});

src/tests/buildScripts.postRelease.test.ts

@@ -0,0 +1,70 @@
+import fs from 'fs';
+import os from 'os';
+import path from 'path';
+import { afterEach, describe, expect, it } from 'vitest';
+
+const {
+  cleanReleaseArtifacts,
+  copyReleaseAssets,
+  getAfterPackLocation,
+  run,
+} = require('../../build-scripts/post-release-assets.js');
+
+function makeTempDir(prefix: string) {
+  return fs.mkdtempSync(path.join(os.tmpdir(), prefix));
+}
+
+describe('post-release-assets helpers', () => {
+  const tempDirs: string[] = [];
+
+  afterEach(() => {
+    for (const dir of tempDirs.splice(0)) {
+      fs.rmSync(dir, { recursive: true, force: true });
+    }
+  });
+
+  it('reads AFTER_PACK_LOC from the environment', () => {
+    expect(getAfterPackLocation({})).toBe('');
+    expect(getAfterPackLocation({ AFTER_PACK_LOC: '  /tmp/rosi-mirror  ' })).toBe(
+      '/tmp/rosi-mirror'
+    );
+  });
+
+  it('cleans build-only release artifacts', () => {
+    const releaseDir = makeTempDir('rosi-release-clean-');
+    tempDirs.push(releaseDir);
+    fs.mkdirSync(path.join(releaseDir, 'win-unpacked'));
+    fs.writeFileSync(path.join(releaseDir, 'builder-debug.yml'), 'debug');
+
+    cleanReleaseArtifacts(releaseDir);
+
+    expect(fs.existsSync(path.join(releaseDir, 'win-unpacked'))).toBe(false);
+    expect(fs.existsSync(path.join(releaseDir, 'builder-debug.yml'))).toBe(false);
+  });
+
+  it('mirrors cleaned release assets to AFTER_PACK_LOC', () => {
+    const releaseDir = makeTempDir('rosi-release-src-');
+    const destination = makeTempDir('rosi-release-dest-');
+    tempDirs.push(releaseDir, destination);
+    fs.writeFileSync(path.join(releaseDir, 'ROSI-Linux-amd64.deb'), 'deb');
+
+    const result = run({
+      releaseDir,
+      env: { AFTER_PACK_LOC: destination },
+    });
+
+    expect(result).toEqual({ mirrored: true, destination: path.resolve(destination) });
+    expect(fs.existsSync(path.join(destination, 'ROSI-Linux-amd64.deb'))).toBe(true);
+    expect(fs.existsSync(path.join(releaseDir, 'ROSI-Linux-amd64.deb'))).toBe(true);
+  });
+
+  it('rejects mirroring into a subdirectory of the release folder', () => {
+    const releaseDir = makeTempDir('rosi-release-nested-');
+    tempDirs.push(releaseDir);
+    fs.writeFileSync(path.join(releaseDir, 'artifact.txt'), 'data');
+
+    expect(() => copyReleaseAssets(releaseDir, path.join(releaseDir, 'mirror'))).toThrow(
+      'AFTER_PACK_LOC cannot be inside the release directory'
+    );
+  });
+});

src/tests/buildScripts.testAll.test.ts

@@ -0,0 +1,15 @@
+import { describe, expect, it } from 'vitest';
+
+const { parseUnitTests, stripAnsi, results } = require('../../build-scripts/test-all.js');
+
+describe('test-all helpers', () => {
+  it('stripAnsi removes terminal color codes', () => {
+    expect(stripAnsi('\u001b[32mPASS\u001b[0m')).toBe('PASS');
+  });
+
+  it('parseUnitTests extracts passed and failed counts', () => {
+    parseUnitTests('Tests  12 passed | 2 failed (14)');
+    expect(results.unit.passed).toBe(12);
+    expect(results.unit.failed).toBe(2);
+  });
+});

src/tests/constants.contract.test.ts

@@ -0,0 +1,41 @@
+import { describe, expect, it } from 'vitest';
+import {
+  ALLOWED_AUDIO_FORMATS,
+  ALLOWED_BROWSERS,
+  ALLOWED_CONVERT_FORMATS,
+  CURRENT_SETTINGS_VERSION,
+  FORMAT_ID_PATTERN,
+  MAX_QUEUE_SIZE,
+  SUBTITLE_LANGS_PATTERN,
+} from '../main/constants';
+
+describe('constants contracts', () => {
+  it('accepts valid yt-dlp format IDs', () => {
+    expect(FORMAT_ID_PATTERN.test('137')).toBe(true);
+    expect(FORMAT_ID_PATTERN.test('hls-1080')).toBe(true);
+    expect(FORMAT_ID_PATTERN.test('136-drc')).toBe(true);
+    expect(FORMAT_ID_PATTERN.test('137; rm -rf /')).toBe(false);
+    expect(FORMAT_ID_PATTERN.test('best audio')).toBe(false);
+  });
+
+  it('accepts valid subtitle language lists', () => {
+    expect(SUBTITLE_LANGS_PATTERN.test('en')).toBe(true);
+    expect(SUBTITLE_LANGS_PATTERN.test('en,es,fr')).toBe(true);
+    expect(SUBTITLE_LANGS_PATTERN.test('en.*')).toBe(true);
+    expect(SUBTITLE_LANGS_PATTERN.test('en; rm -rf /')).toBe(false);
+  });
+
+  it('keeps allowed format and browser sets aligned with validation', () => {
+    expect(ALLOWED_CONVERT_FORMATS.has('mp4')).toBe(true);
+    expect(ALLOWED_CONVERT_FORMATS.has('avi')).toBe(false);
+    expect(ALLOWED_AUDIO_FORMATS.has('m4a')).toBe(true);
+    expect(ALLOWED_AUDIO_FORMATS.has('wma')).toBe(false);
+    expect(ALLOWED_BROWSERS.has('firefox')).toBe(true);
+    expect(ALLOWED_BROWSERS.has('internet explorer')).toBe(false);
+  });
+
+  it('keeps queue and settings version contracts stable', () => {
+    expect(MAX_QUEUE_SIZE).toBe(500);
+    expect(CURRENT_SETTINGS_VERSION).toBeGreaterThanOrEqual(1);
+  });
+});