fix: accept async/sync middleware on onOriginRequest / onOriginResponse#78
Open
stefanmaric wants to merge 4 commits into
Open
Conversation
…ponse` `onOriginRequest`'s old `Promise<Request> | Promise<Response>` signature doesn't accept `async` callbacks returning a mix of the two: TS infers `Promise<Request | Response>` for them, which is a supertype the narrower union won't accept. Flagged in BunnyWay#63 and partially fixed in BunnyWay#64 (which only touched the ambient declaration). Widen both hooks, with sync returns too: * `onOriginRequest`: `(ctx) => Request | Response | Promise<Request | Response>` * `onOriginResponse`: `(ctx) => Response | Promise<Response>` Same shape as `ServerHandler`, strictly wider, nothing breaks. Internal middleware arrays and the ambient `Bunny.v1.registerMiddlewares` get the same widening; runtime is unchanged since both call sites already `await mid(...)`. `src/net/serve.test.ts` covers sync, async, and mixed at the type level.
jamie-at-bunny
requested changes
Jun 18, 2026
jamie-at-bunny
left a comment
jamie-at-bunny
left a comment
Member
There was a problem hiding this comment.
@stefanmaric solid PRk, this is great. One comment
| }; | ||
|
|
||
| // Plain function returning `Promise.resolve(...)` — the classic workaround. | ||
| const _promiseResolve: OnRequest = (ctx) => { |
Member
There was a problem hiding this comment.
Minor nitpick, but we could probably drop this. The inferred type ends up being the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onOriginRequest's oldPromise<Request> | Promise<Response>signaturedoesn't accept
asynccallbacks returning a mix of the two: TS infersPromise<Request | Response>for them, which is a supertype the narrowerunion won't accept. Flagged in #63 and partially fixed in #64 (which only
touched the ambient declaration).
Widen both hooks, with sync returns too:
onOriginRequest:(ctx) => Request | Response | Promise<Request | Response>onOriginResponse:(ctx) => Response | Promise<Response>Same shape as
ServerHandler, strictly wider, nothing breaks. Internalmiddleware arrays and the ambient
Bunny.v1.registerMiddlewaresget thesame widening; runtime is unchanged since both call sites already
await mid(...).src/net/serve.test.tscovers sync, async, and mixed at the type level.