Feature/widget placement improvements#72
Conversation
There was a problem hiding this comment.
Sorry @crustytaco, your pull request is larger than the review limit of 150000 diff characters
|
Hey. Thanks for opening this PR. I know this was something you originally built for your own use, and I appreciate you taking the time to turn it into a PR. With that said, the current version is extremely large and introduces a lot of things at once, which makes it tough to review and merge into the project. The core idea of having an edit mode that can be turned on and off is solid and something that could work really well in TablissNG. The problem is that the implementation here is much more complex than we need, and the overall style does not match the rest of the application. It uses a very futuristic look with a lot of heavy effects, and it ends up clashing with the existing simplistic design. If you want, we can figure out a more focused version that keeps the good parts and fits the project more cleanly. Let me know how you want to move forward. |
|
@crustytaco Just making sure you see this. No pressure! :) |
|
Hello!!! Absolutely! I am removing all the bells and whistles to match the current styles! :) did we want to keep the text and code editor popouts as well? |
Thanks! You can keep the text and code editors if you want. We'll see how it turns out, then decide. i'm not sure how else we would be able to edit text inside "edit mode", so TLDR yes lol. |
|
@crustytaco No pressure, but any progress? |
|
Hey @crustytaco, I'm going to close this pr for now because of inactivity, but feel free to ping me/re-open it! |
Hey! Sorry, been working around the clock on a project for work haha. I'll definitely reopen it as soon as i'm finished! |
|
Hello! @BookCatKid I've nearly completed the edits! Are we able to reopen this? :) |
|
I don't see any new commits, but sure! |
1c3e788 to
851539a
Compare
|
Please merge main and resolve merge conflicts. Good luck with that 🫡 |
|
Latest commit was cleanup/follow-up work:
The earlier Sourcery security review threads are resolved/outdated after the DOMPurify rich-text sanitization updates. This should be ready for re-review. |
|
Hello! Sorry for the extra updates here. I realized I needed to clean up a couple of translation items, and then the branch had a pnpm-lock.yaml conflict after upstream changed, so I merged the latest main and regenerated the lockfile. |
|
All checks are passing now, and the react-markdown dependency issue has been fixed in the latest commit. This should be ready for maintainer review/merge when you have a chance. |
Description
Type of Change
Changelog Entry
Added a full-featured rich text editor for text-based widgets, expanded widget settings persistence, and refreshed widget/fon`t settings UI with viewport-aware positioning.
Screenshots
Included in issue discussion / PR comment thread (dashboard widget settings flyout + font settings modal).
Related Issues
#70
Checklist
npm run translations