Skip to content

Feature/widget placement improvements#72

Open
crustytaco wants to merge 9 commits into
BookCatKid:mainfrom
crustytaco:feature/Widget-Placement-Improvements
Open

Feature/widget placement improvements#72
crustytaco wants to merge 9 commits into
BookCatKid:mainfrom
crustytaco:feature/Widget-Placement-Improvements

Conversation

@crustytaco

@crustytaco crustytaco commented Dec 5, 2025

Copy link
Copy Markdown

Description

  • Added the Text Widget Editor overlay plus a Rich Text Editor toolbar for Notes, Message, and Custom Text widgets, including sanitation utilities and snippet support.
  • Updated widget components, UI context, and data models so rich-text HTML is saved safely, with a refreshed Widget Font Settings modal for consistent typography controls.
  • Improved the widget settings flyout: it now clamps to the viewport, shows plugin-specific settings for non-Text/Code widgets via [PluginContainer]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Translation update

Changelog Entry

Added a full-featured rich text editor for text-based widgets, expanded widget settings persistence, and refreshed widget/fon`t settings UI with viewport-aware positioning.

Screenshots

Included in issue discussion / PR comment thread (dashboard widget settings flyout + font settings modal).

Related Issues

#70

Checklist

  • Tested in development environment
  • Tested in Firefox
  • Tested in Chrome/Edge
  • Added or updated unit tests (if applicable)
  • All new and existing tests passed
  • I have added a changelog entry
  • I ran npm run translations
  • This PR is ready to be merged

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @crustytaco, your pull request is larger than the review limit of 150000 diff characters

@BookCatKid

Copy link
Copy Markdown
Owner

Hey. Thanks for opening this PR.

I know this was something you originally built for your own use, and I appreciate you taking the time to turn it into a PR. With that said, the current version is extremely large and introduces a lot of things at once, which makes it tough to review and merge into the project.

The core idea of having an edit mode that can be turned on and off is solid and something that could work really well in TablissNG. The problem is that the implementation here is much more complex than we need, and the overall style does not match the rest of the application. It uses a very futuristic look with a lot of heavy effects, and it ends up clashing with the existing simplistic design.

If you want, we can figure out a more focused version that keeps the good parts and fits the project more cleanly. Let me know how you want to move forward.

@BookCatKid

Copy link
Copy Markdown
Owner

@crustytaco Just making sure you see this. No pressure! :)

@crustytaco

Copy link
Copy Markdown
Author

Hello!!! Absolutely! I am removing all the bells and whistles to match the current styles! :) did we want to keep the text and code editor popouts as well?

@BookCatKid

Copy link
Copy Markdown
Owner

Hello!!! Absolutely! I am removing all the bells and whistles to match the current styles! :) did we want to keep the text and code editor popouts as well?

Thanks! You can keep the text and code editors if you want. We'll see how it turns out, then decide. i'm not sure how else we would be able to edit text inside "edit mode", so TLDR yes lol.

@BookCatKid

Copy link
Copy Markdown
Owner

@crustytaco No pressure, but any progress?

@BookCatKid

Copy link
Copy Markdown
Owner

Hey @crustytaco, I'm going to close this pr for now because of inactivity, but feel free to ping me/re-open it!

@BookCatKid BookCatKid closed this Jan 14, 2026
@crustytaco

Copy link
Copy Markdown
Author

Hey @crustytaco, I'm going to close this pr for now because of inactivity, but feel free to ping me/re-open it!

Hey! Sorry, been working around the clock on a project for work haha. I'll definitely reopen it as soon as i'm finished!

@crustytaco

crustytaco commented May 21, 2026

Copy link
Copy Markdown
Author

Hello! @BookCatKid I've nearly completed the edits! Are we able to reopen this? :)

@BookCatKid

BookCatKid commented May 21, 2026

Copy link
Copy Markdown
Owner

I don't see any new commits, but sure!

@BookCatKid BookCatKid reopened this May 21, 2026
@crustytaco crustytaco force-pushed the feature/Widget-Placement-Improvements branch from 1c3e788 to 851539a Compare May 21, 2026 03:24
@BookCatKid

Copy link
Copy Markdown
Owner

Please merge main and resolve merge conflicts. Good luck with that 🫡

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New security issues found

Comment thread src/utils/richText.ts Outdated
Comment thread src/utils/richText.ts Outdated
Comment thread src/utils/richText.ts Outdated
Comment thread src/utils/richText.ts Outdated
Comment thread src/views/dashboard/RichTextEditor.tsx Outdated
Comment thread src/views/dashboard/RichTextEditor.tsx Outdated
@crustytaco

Copy link
Copy Markdown
Author

Latest commit was cleanup/follow-up work:

  • Fixed widget settings prop/type errors by adding the missing defaultData handling.
  • Cleaned up related formatting/type issues.
  • Updated the FormatJS command resolution to use the local @formatjs/cli binary.
  • Re-ran translations after the changes.

The earlier Sourcery security review threads are resolved/outdated after the DOMPurify rich-text sanitization updates. This should be ready for re-review.

@crustytaco

Copy link
Copy Markdown
Author

Hello! Sorry for the extra updates here. I realized I needed to clean up a couple of translation items, and then the branch had a pnpm-lock.yaml conflict after upstream changed, so I merged the latest main and regenerated the lockfile.

@crustytaco

Copy link
Copy Markdown
Author

All checks are passing now, and the react-markdown dependency issue has been fixed in the latest commit. This should be ready for maintainer review/merge when you have a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants