Feat/screenshot bank - #61
Merged
Merged
Conversation
- Replace deviceConnected with deviceKey (serial:platform:physical) in the metrics capture effect so a direct A→B device switch re-runs the effect, stopping the old collector and clearing stale samples before the new one starts — prevents misattributed data. - Guard run_loop / run_loop_ios_sim self-clear against stop()→start() race: track exit_by_cancel and skip the tokio::spawn self-clear on cancel exits, since stop() already .take()s the RUNNING slot. - Distinguish Ok(None) from Err(e) in ios-sim cpu_mem match: errors now increment consecutive_errors and trigger MAX_CONSECUTIVE_ERRORS bail with emit_stopped, matching the pid-resolution path.
… reviewable diffs Adds runTarget to runStore, sets it before each ipc.runFlow call in MainView, creates reviewStore with setReport/next/close queue logic, and wires compareScreenshots in App.tsx onRunnerExit (pid captured before setStopped clears it).
… guard, dimension-mismatch handling
BlueShork
force-pushed
the
feat/screenshot-bank
branch
from
July 7, 2026 19:05
189b5a4 to
6666e6d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
What
Why
Closes #
How
Checklist
feat(inspector): ...)pnpm typecheck && pnpm lintpassescargo fmt --check && cargo clippy -- -D warningspassescargo test --libpassesunwrap()/expect()in production code paths