VV: BadDataNeighborOrientationCheck + ComputeFeatureFaceMisorientation V&V'ed#1628
Closed
imikejackson wants to merge 3 commits into
Closed
Conversation
nyoungbq
reviewed
Jun 2, 2026
imikejackson
force-pushed
the
vv/compute_feature_face_misorientations
branch
5 times, most recently
from
de7a718 to
a364b3c
Compare
(cherry picked from commit 3291bf2)
(cherry picked from commit 0e8bcd4)
…on V&V'ed BadDataNeighborOrientationCheck: - Confirmed no SIMPLNX-side bugs (D1 was landed pre-V&V in PR BlueQuartzSoftware#1499; D2 was SIMPLNX-correct from rewrite onward); - documented 2 deviations from DREAM3D 6.5.171 (D1 iterative-decay loop bound `>` should be `>=`, D2 stale-w threshold check leaks across different-phase neighbors); - retired 1 test (legacy 6_6 exemplar-comparison TEST_CASE — replaced with the engineer's hand-derived 27-fixture dataset); - unit tests replaced with 27 hand-derived Class 1 (Analytical) base fixtures + 18 Class 4 (Invariant) Invariants-Sweep DYNAMIC_SECTIONs + 1 Class 4 Idempotence test + 1 inlined 2D Image fixture (31 TEST_CASEs / 49 ctest entries, 100% pass); - added 3 V&V source-tree deliverables (report, deviations, provenance); - restored bad_data_neighbor_orientation_check_v2.tar.gz archive download in test/CMakeLists.txt. Compute Feature Face Misorientation: - Confirmed no SIMPLNX-side bugs (D3 fix corrects a legacy 6.5.171 bug — SIMPLNX has been correct since the rewrite); - documented 4 deviations from DREAM3D 6.5.171 (D1 9 additional Laue classes now supported, D2 1-component magnitude output vs legacy 3-component axis·angle, D3 NaN sentinel for unprocessed faces vs legacy implicit 0, D4 EbsdLib 2.4.1 CubicOps precision improvement); - retired 1 test ("Invalid filter execution" — preflight-failure paths made unreachable by D3's NaN-on-invalid-face semantics); - unit tests replaced with 1 hand-built Class 1 (Analytical) 37-fixture dataset (30 normal cases across all 11 EbsdLib Laue classes × 3 pure-φ1 boundaries + 4 edge cases + 3 Trigonal_High cases) + 1 SIMPL 6.4/6.5 backwards-compat; - added 3 V&V source-tree deliverables (report, deviations, provenance); - fixed user-facing doc.
imikejackson
force-pushed
the
vv/compute_feature_face_misorientations
branch
from
a364b3c to
5949895
Compare
imikejackson
changed the title
Contributor
Author
|
Taken over by #1631 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.