fix: fixes tests on windows#307
Merged
delta1 merged 1 commit intoBlockstreamResearch:masterfrom May 4, 2026
Merged
Conversation
Contributor
Author
|
Failing test can be seen here https://github.com/BlockstreamResearch/SimplicityHL/actions/runs/25163057573/job/73762146313?pr=308 |
KyrylR
added a commit
that referenced
this pull request
May 8, 2026
47a56a5 chore(ci): add windows build job to rust workflow (stringhandler) Pull request description: Add a CI job to run tests on windows. #303 broke `cargo test` on windows (fixed in #307). This is a job to check that tests pass on windows ACKs for top commit: KyrylR: ACK 47a56a5; ran tests locally, code review Tree-SHA512: 98e22971454668108b5391c3fd868350097b2e4f8c8db623522319814e2e98ec01f8e8b274c4d4513b6bced0660943c7909e13e3e5fff62522a509219fc70bfe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo testis currently broken on Windows. This should fix it.