chore(bitcoin): v31.1 - #5
Open
DeviaVir wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates this repository’s bitcoind build tooling/documentation to default to Bitcoin Core 31.1 (from 31.0), aligning binary downloads, Guix source builds, and compatibility shims with the current upstream patch release.
Changes:
- Bumped default downloaded-binary version in
bitcoind/Dockerfileandbuild-and-push-to-dockerhub.shto31.1. - Bumped default Guix source tag in
run-guix.shtov31.1. - Updated README links and Gitian-compatibility messaging/comments to reference 31.1.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| bitcoind/run-guix.sh | Sets the default Guix build tag to v31.1. |
| bitcoind/run-gitian.sh | Updates the deprecation message while continuing to forward to run-guix.sh. |
| bitcoind/README.md | Updates default version text and Guix documentation links to v31.1. |
| bitcoind/Dockerfile.gitian | Keeps the Gitian Dockerfile alias comment aligned with 31.1/Guix guidance. |
| bitcoind/Dockerfile | Bumps default BITCOIN_VERSION used for downloading official binaries to 31.1. |
| bitcoind/build-and-push-to-dockerhub.sh | Bumps default VER used for image builds/pushes to 31.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #!/usr/bin/env bash | ||
|
|
||
| echo "run-gitian.sh is deprecated for Bitcoin Core 31.0; use run-guix.sh instead." >&2 | ||
| echo "run-gitian.sh is deprecated for Bitcoin Core 31.1; use run-guix.sh instead." >&2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Bitcoin Core 31.1 is the current upstream patch release. The official amd64 and arm64 archives from bitcoincore.org matched
SHA256SUMS, and the signed checksum manifest verified against the existing Ava Chow fingerprint.Impact
After the image build is run from the merged change, the default
blockstream/bitcoindbuild will produce 31.1. This PR does not publish or retag a Docker image.Validation
sh -n bitcoind/build-and-push-to-dockerhub.shbash -n bitcoind/run-guix.sh bitcoind/run-gitian.shdocker buildx build --platform linux/amd64 --loadusing the default versionbitcoind --versionreportedv31.1.0