[rehearsal 3] Device robustness: BIP-85, BIP-39 recovery validation, fault-injection hardening#296
Open
BitHighlander wants to merge 10 commits into
Open
[rehearsal 3] Device robustness: BIP-85, BIP-39 recovery validation, fault-injection hardening#296BitHighlander wants to merge 10 commits into
BitHighlander wants to merge 10 commits into
Conversation
(cherry picked from commit 951769f)
(cherry picked from commit 431969d)
1. Per-word rejection: invalid BIP-39 words rejected immediately during cipher entry with "Word not found in BIP39 wordlist" + OLED warning 2. Condition flip: !enforce_wordlist -> enforce_wordlist at finalization 3. Previous word display: shows "(N.word)" during cipher entry 4. layout_cipher: added prev_word_info parameter C31 test should now PASS with OLED screenshot. (cherry picked from commit da3a62d)
(cherry picked from commit a0be7a5)
(cherry picked from commit a66e744)
Derive child mnemonics per BIP-85 spec and display them on the device screen. Mnemonic is NEVER sent over USB — display only, with explicit user confirmation before showing. Supports 12/18/24 word outputs with configurable BIP-39 app index. All sensitive buffers are zeroed on every exit path. (cherry picked from commit aecdc1d)
…eclaration (cherry picked from commit 91bdd34)
(cherry picked from commit 03534e2)
(cherry picked from commit 8810d72)
…nstVariablePointer) Zero-warning policy: cppcheck flagged fsm_msg_bip85.h:65 tok as declarable pointer-to-const. Read-only use; no codegen change. (cherry picked from commit bc5f147)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dress-rehearsal PR 3/5 (stacks on #295). Independent robustness features. Local kkemu + firmware-unit green.