You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The change is minimal and focused. All five methods are simple delegations to existing fields, with Javadoc explaining the compatibility purpose. The @NotNull contract on getPlayer() is reasonable given the event should only fire for online players. No issues with the diff — it matches the stated PR intent of adding CLV EXP event compatibility aliases. The getAmount/setAmount pair is the only mutable exposure here; worth noting that callers using setAmount will mutate the same expAmount field used by the rest of the event pipeline, which is presumably intentional but is a footgun if any listener caches the value before calling setAmount.
Changes:
The version bump and CyberCore dependency refresh in build.gradle.kts and the JAR are routine.
The core change is in ExpChangeEvent.java — five new methods added as compatibility aliases for integrations:
getPlayer() — delegates to user.getPlayer() for reflection-based hooks that expect a direct Bukkit player accessor.
getAmount() / setAmount(double) — legacy-style getter/setter for the mutable EXP delta (expAmount).
getOldXP() / getNewXP() — legacy-style accessors for the before/after EXP values (oldExp / newExp).
Reviewed changes
No blocking or high-confidence comments.
Reviewed 3 changed files in this pull request and generated no inline comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commits
Need help on this PR? Tag
@codesmithwith what you need.