Claude/nifty archimedes#94
Merged
Merged
Conversation
The monitor worker runs as 'python -m workers.monitor.worker' because it uses package-relative imports. 'python -m' only puts the current working directory on sys.path, so deployments that launch the container with a working directory other than /app failed with 'No module named workers'. - Set PYTHONPATH=/app in the monitor Dockerfile so the workers package resolves regardless of the runtime working directory. - Fix setuptools package discovery in pyproject.toml: 'where' pointed inside each first-party directory, so discovered names never matched the 'include' filter and no first-party packages were installed by 'pip install .'. Scan from the repo root and keep the top-level packages so shepherd_utils, workers.monitor, etc. are importable after install.
…umentation shepherd_utils/otel.py imported JaegerExporter from the deprecated opentelemetry-exporter-jaeger package but never used it -- tracing already exports via OTLP. Loading that package's __init__ imports OTEL_EXPORTER_JAEGER_AGENT_HOST from opentelemetry.sdk.environment_variables, a constant removed in newer SDK releases. In environments using the OpenTelemetry Operator's Python auto-instrumentation, a newer opentelemetry-sdk is prepended to PYTHONPATH (via /otel-auto-instrumentation-python), shadowing the pinned sdk==1.16.0. The deprecated Jaeger exporter then fails to import that constant, crashing server startup. Deployments without auto-instrumentation run only the pinned SDK where the constant still exists, so they were unaffected. Drop the unused import (and the commented-out Jaeger block) and remove the opentelemetry-exporter-jaeger dependency, eliminating the conflict with no change to tracing behavior.
Codecov Report✅ All modified and coverable lines are covered by tests.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.