Standardize databaseStart separator to comma in tests#87
Merged
Conversation
Six rows in test-recode-with-table.R used ";" to separate databases in the databaseStart column, while the rest of the project (production code, sample data, integration fixtures, vignettes) uses ",". The semicolon cases only passed because rec_with_table uses grepl() for database matching, which is separator-agnostic. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/testthat/test-recode-with-table.Rused;to separate databases in thedatabaseStartcolumn, while the rest of the project (production code, sample data, integration fixtures, vignettes) uses,.rec_with_tableusesgrepl()for database matching, which is separator-agnostic — so the inconsistency was silently tolerated, not exercised."database_one;database_two"with"database_one, database_two"to match the comma-space convention used everywhere else.Test plan
devtools::test()— full suite passes (58/58)🤖 Generated with Claude Code