Add all modules and main script#1
Open
BeskrovnaiaM wants to merge 2 commits into
Open
Conversation
Comment on lines
+1
to
+5
| import sys | ||
| import modules.dna_rna_tools as dr | ||
| import modules.protein_tool as p | ||
| import modules.fastqc_filter as f | ||
| from typing import Dict, List, Union |
There was a problem hiding this comment.
Все супер, только вот импорты из стандартной библиотеки всегда идут до импортов собственной библиотеки и разделяются пустыми строками
Плюс я была бы поосторожнее с собственными именами пакетов вроде dr, p, f - они хоть и могут быть короче, но лучше, чтобы оставались уникальными и информативными
Suggested change
| import sys | |
| import modules.dna_rna_tools as dr | |
| import modules.protein_tool as p | |
| import modules.fastqc_filter as f | |
| from typing import Dict, List, Union | |
| import sys | |
| from typing import Dict, List, Union | |
| import modules.dna_rna_tools as dr | |
| import modules.protein_tool as p | |
| import modules.fastqc_filter as f | |
Comment on lines
+11
to
+14
| for name, (sequence, quality) in seqs.items(): | ||
| if name in filter_set: | ||
| result[name] = (sequence, quality) | ||
| return result |
Comment on lines
+2
to
+6
| length_output = [] | ||
| for name, (sequence, quality) in seqs.items(): | ||
| if len(sequence) <= length_bounds[1] and len(sequence) >= length_bounds[0]: | ||
| length_output.append(name) | ||
| return length_output |
There was a problem hiding this comment.
увы, не предусмотрен вариант, где пользователь передает только одну границу (тип int), и тогда она назначается верхней, а нижняя граница будет 0
| for name, (sequence, quality) in seqs.items(): | ||
| score_nuc_count = 0 | ||
| for score in quality: | ||
| score_nuc_count += ord(score) - 33 |
| if nuc == 'G' or nuc == 'C': | ||
| gc_nuc_count += 1 | ||
| gc_count = gc_nuc_count/len(sequence)*100 | ||
| if gc_count <= gc_bounds[1] and gc_count >= gc_bounds[0]: |
There was a problem hiding this comment.
увы, не предусмотрен вариант, где пользователь передает только одну границу (тип int), и тогда она назначается верхней, а нижняя граница будет 0
| for nuc in sequence: | ||
| if nuc == 'G' or nuc == 'C': | ||
| gc_nuc_count += 1 | ||
| gc_count = gc_nuc_count/len(sequence)*100 |
There was a problem hiding this comment.
PEP8, пробелы
Suggested change
| gc_count = gc_nuc_count/len(sequence)*100 | |
| gc_count = gc_nuc_count / len(sequence) * 100 |
| score_nuc_count = 0 | ||
| for score in quality: | ||
| score_nuc_count += ord(score) - 33 | ||
| score_seq_count = score_nuc_count/len(sequence) |
There was a problem hiding this comment.
PEP8, пробелы
Suggested change
| score_seq_count = score_nuc_count/len(sequence) | |
| score_seq_count = score_nuc_count / len(sequence) |
|
Комментарии:
Итог:
Штрафы и бонусы:
Итог: 9 баллов |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.