Skip to content

Make visibility pruning test deterministic#447

Open
lola831 wants to merge 2 commits intoBerkeleyLearnVerify:mainfrom
lola831:fix-visibility-pruning-flake
Open

Make visibility pruning test deterministic#447
lola831 wants to merge 2 commits intoBerkeleyLearnVerify:mainfrom
lola831:fix-visibility-pruning-flake

Conversation

@lola831
Copy link
Copy Markdown
Collaborator

@lola831 lola831 commented Apr 3, 2026

Description

This updates test_visibility_pruning to reduce flakiness. The test previously relied on random sampling to hit the outer valid band of the pruned region, which could occasionally fail even when pruning was correct. It now checks the conditioned/pruned region directly to confirm that the outer band is still available, while still verifying that sampled positions stay within the expected distance bounds.

Issue Link

N/A

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

N/A

@lola831 lola831 requested a review from dfremont April 3, 2026 15:32
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.72%. Comparing base (07625cb) to head (009ccfc).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   89.66%   89.72%   +0.06%     
==========================================
  Files          48       48              
  Lines       13193    13194       +1     
==========================================
+ Hits        11829    11838       +9     
+ Misses       1364     1356       -8     

see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant