Total sound death fix - #2910
Conversation
…aking sound makes sense I am completely fried.
|
Please update your changelog to actually reflect your changes. I'd also rather have all of the channels here actually set to something that's not a random available one, but I won't punish you for finding a bug and fixing it by forcing you to, and I appreciate you already doing that for several of them regardless. :p |
I'll be honest, at some point my brain gave up and I stopped thinking about it |
I fixed missing sound channels across the game, hopefully preventing all instances of all channels being purged without intention to do so from happening.
no more mental bandwidth for more at this moment
Also fixed a years old typo in sound channel datums
I went through and fixed every instance of SEND_SOUND() and RELAY() without a channel by hand
also can confirm stop_sounds was not broken. I intentionally did not fix it for a few instances where it makes sense.
About The Pull Request
Why It's Good For The Game
Testing Photographs and Procedure
Screenshots&Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: fixed sounds using every channel in the game occasionally by making sure all sounds barring a few have a set channel
fix: fixed a years old typo in soundchannels
/:cl: