Adds a station boarding mission - #2823
Conversation
And also let me make the mission fully work
|
Can we get a whole metastation next? |
| return COMSIG_SHIP_BLOCKS_RELEASE_BOARDING | ||
| return 0 | ||
|
|
||
| /datum/overmap_objective/board_station/proc/iff_change() |
There was a problem hiding this comment.
SIGNAL_HANDLER
Also the comsig for this is currently sent before actually changing the faction - maybe use the unimplemented comsig you added?
There was a problem hiding this comment.
This isn't resolved. COMSIG_SHIP_IFF_CHANGE (triggering this proc's call) is sent before faction changes (not after, as the if in this proc assumes)
Additionally, for compatibility with SIGNAL_HANDLER, just moving the reinforcements part into an async-called proc would work.
(I've also noticed the COMSIG_SHIP_KILLED_FLEET register seems a bit fishy, since this comsig is only sent to objects that have mobs within them (which if they station is left it isn't going to have), aswell as triggering on any fleet destruction. Is there a reason it doesn't just register the COMSIG_PARENT_QDELETING signal on the reinforcement fleet?)
There was a problem hiding this comment.
Thanks for the second comment, I'll look at it some more then and refactor it properly. Honestly haven't had to work with signals much so I appreciate the help. 👍
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
3 participants
About The Pull Request
Adds a board station mission. The objective is to defeat a fleet and capture the station they're defending. After that, you will have to defend the station from an enemy boarding fleet.
Why It's Good For The Game
More objective variety!
Testing Photographs and Procedure
Screenshots&Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
add: Added a new mission about boarding and defending a station
/:cl: