Improve a lot#17
Conversation
Signed-off-by: Bechma <19294519+Bechma@users.noreply.github.com>
Signed-off-by: Bechma <19294519+Bechma@users.noreply.github.com>
Signed-off-by: Bechma <19294519+Bechma@users.noreply.github.com>
Signed-off-by: Bechma <19294519+Bechma@users.noreply.github.com>
| [package] | ||
| name = "cargo-gears-macros" | ||
| version.workspace = true | ||
| version = "0.0.1" |
There was a problem hiding this comment.
because we are not going to release it for now along the other crates, as this crate will be untouched for now, as we don't require macros for now, after the latest changes
| /// Main application configuration with strongly-typed global sections | ||
| /// and a flexible per-module configuration bag. | ||
| #[derive(Clone, Deserialize, Serialize, crate::HelpSchema)] | ||
| #[derive(Clone, Deserialize, Serialize, schemars::JsonSchema)] |
| } | ||
|
|
||
| #[derive(Clone, Debug, Serialize, Deserialize, schemars::JsonSchema)] | ||
| pub struct Section { |
There was a problem hiding this comment.
What is this Section? Config section? These names (Section, Level, Value, etc.) look a bit confusing to me.
There was a problem hiding this comment.
Section is extracted from gears-rust https://github.com/constructorfabric/gears-rust/blob/main/libs/toolkit/src/bootstrap/config/mod.rs#L253-L268
This is added to align with the main config
| } | ||
| } | ||
|
|
||
| pub const BUILTIN_TEMPLATES_GEARS: &[TemplateDefinition] = &[ |
There was a problem hiding this comment.
So, it's hard-coded here? That means that every new template would require a new release. Not sure how frequent that will be, so, this can be manageable.
Having a hard-coded list gives more control, and some amount of meta-data (description) that could be useful and simpler to maintain.
Not against this; just trying to identify pros and cons.
There was a problem hiding this comment.
For now it will be like this, next iteration we should have our own simple registry where the tool will query against
| SystemRegistryModule { | ||
| module_name: "module-orchestrator", | ||
| crate_name: "cf-module-orchestrator", | ||
| crate_name: "cf-gears-module-orchestrator", |
There was a problem hiding this comment.
I guess this module is here to stay, right? 🙂
Signed-off-by: Bechma <19294519+Bechma@users.noreply.github.com>
2 participants
No description provided.