Skip to content

Drop minor version (NEEDS TESTING) - #773

Open
Xabi08YT wants to merge 4 commits into
BeardOverflow:mainfrom
Xabi08YT:DropMinorVersion
Open

Drop minor version (NEEDS TESTING)#773
Xabi08YT wants to merge 4 commits into
BeardOverflow:mainfrom
Xabi08YT:DropMinorVersion

Conversation

@Xabi08YT

@Xabi08YT Xabi08YT commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Hi,

I just finished the rework on version check during module load.
However, I cannot test that since I only have access to WSL atm (Intel please publish the freacking patch).

So if someone could test it would be great. Some regression may occur since I did some deduplicating.

I also tried adding a blacklist but it should also be tested. I know that it is not needed now but it may be used one day or another.

Like always, no AI. So if you want to check.

@EricLin0509

Copy link
Copy Markdown

@Xabi08YT

Hi, I just tested your commits, but it cause 2 compilation errors

msi-ec.c:60:2: error: expected ';' after top level declarator
   60 | }
      |  ^
      |  ;


msi-ec.c:2831:53: error: expected ';' after expression
 2831 |                 pr_err("Your firmware version is blacklisted !\n")
      |                                                                   ^
      | 

I'm using my own forks with your commits

@Xabi08YT

Copy link
Copy Markdown
Contributor Author

@Xabi08YT

Hi, I just tested your commits, but it cause 2 compilation errors

msi-ec.c:60:2: error: expected ';' after top level declarator
   60 | }
      |  ^
      |  ;


msi-ec.c:2831:53: error: expected ';' after expression
 2831 |                 pr_err("Your firmware version is blacklisted !\n")
      |                                                                   ^
      | 

I'm using my own forks with your commits

Thank you very much. I will correct that right away

Xabi08YT added 2 commits July 26, 2026 12:24
corrected one problem with ; on declaring Blacklist
Fixed another missing no mouth winkey boy (;)
@Xabi08YT

Copy link
Copy Markdown
Contributor Author

@EricLin0509 Thank you it should be fixed

@Xabi08YT

Copy link
Copy Markdown
Contributor Author

Hello @glpnk,
I just wanted to check if you had time to test the PR ?
Also, small question, do we keep the version check like this or do we edit it to use the sku number as you suggested ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants