Drop minor version (NEEDS TESTING) - #773
Open
Xabi08YT wants to merge 4 commits into
Open
Conversation
|
Hi, I just tested your commits, but it cause 2 compilation errors I'm using my own forks with your commits |
Contributor
Author
Thank you very much. I will correct that right away |
corrected one problem with ; on declaring Blacklist
Fixed another missing no mouth winkey boy (;)
Contributor
Author
|
@EricLin0509 Thank you it should be fixed |
Contributor
Author
|
Hello @glpnk, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I just finished the rework on version check during module load.
However, I cannot test that since I only have access to WSL atm (Intel please publish the freacking patch).
So if someone could test it would be great. Some regression may occur since I did some deduplicating.
I also tried adding a blacklist but it should also be tested. I know that it is not needed now but it may be used one day or another.
Like always, no AI. So if you want to check.