Closed
Conversation
Fix/blueprint: Add SVG support and update landing page
Style: Apply WordPress coding standards to blockparty-modal
- Update the landing page to use the newly created demo page slug. - Fix PHP syntax errors and nested tags in the page creation step. - Expand the KSES allowed HTML filter to include the `` element and its attributes. - Replace base64 MU-plugin installation with a more readable PHP implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: adds an optional new block attribute and editor control, with a simple fallback to the existing default label; no auth or data-handling changes.
Overview
Adds a new
closeButtonLabelattribute to the modal block and exposes it in the editor sidebar so authors can override the close button text (falling back to the existing translated default when unset).Updates the saved/rendered markup to output the custom label when provided, and refreshes i18n catalogs plus the Playground
blueprint.jsondemo setup (landing page, mu-plugin for allowed tags, and demo page slug).Reviewed by Cursor Bugbot for commit 43dc970. Bugbot is set up for automated code reviews on this repo. Configure here.