Add local engine to read playback frames from NDJSON files.#75
Open
Schoonology wants to merge 2 commits into
Open
Add local engine to read playback frames from NDJSON files.#75Schoonology wants to merge 2 commits into
local engine to read playback frames from NDJSON files.#75Schoonology wants to merge 2 commits into
Conversation
Uses a single environment variable and a GET /replays/{id} with two
fields: `info` metadata and `frames` replay.
Author
|
This code also isn't robust to a lot of edge cases, though in my experience it doesn't crash from things like missing files. (That might just be Vite catching and restarting, though.) I'm happy to make this as resilient as y'all want before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reads the new playback-optimized replay files from
rules, given theenginesetting of"local". Files are, by default, read fromprocess.cwd(), but can be read from another location via theREPLAYS_DIRenvironment variable.In other words, asking for
?game=1234&engine=localwill read from${REPLAYS_DIR}/1234.ndjson.Requested feedback (also left as TODO comments in context, in case we intend to address these in the future):
.ndjson?---like it's front matter, or use a JSON-compatible value like the empty object,{}.