feat: add values schema#60
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new JSON schema file, values.schema.json, to validate the agent.flavor property. The reviewer suggests expanding this schema to include other critical properties, such as global.imageRegistry and controller.replicas, to ensure more robust configuration validation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "properties": { | ||
| "agent": { | ||
| "type": "object", | ||
| "properties": { | ||
| "flavor": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "base", | ||
| "metax" | ||
| ], | ||
| "default": "base" | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The current schema only validates the agent.flavor property. To make the schema validation more robust and prevent configuration errors, it is highly recommended to expand the schema to cover other critical properties defined in values.yaml, such as global.imageRegistry and controller.replicas (which should be a positive integer).
"properties": {
"global": {
"type": "object",
"properties": {
"imageRegistry": {
"type": "string"
}
}
},
"agent": {
"type": "object",
"properties": {
"flavor": {
"type": "string",
"enum": [
"base",
"metax"
],
"default": "base"
}
}
},
"controller": {
"type": "object",
"properties": {
"replicas": {
"type": "integer",
"minimum": 1
}
}
}
}
No description provided.