Skip to content

feat: add values schema#60

Merged
izturn merged 1 commit into
mainfrom
feat/val-schema
Jul 16, 2026
Merged

feat: add values schema#60
izturn merged 1 commit into
mainfrom
feat/val-schema

Conversation

@izturn

@izturn izturn commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@izturn
izturn merged commit b37c1bb into main Jul 16, 2026
2 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new JSON schema file, values.schema.json, to validate the agent.flavor property. The reviewer suggests expanding this schema to include other critical properties, such as global.imageRegistry and controller.replicas, to ensure more robust configuration validation.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +4 to +18
"properties": {
"agent": {
"type": "object",
"properties": {
"flavor": {
"type": "string",
"enum": [
"base",
"metax"
],
"default": "base"
}
}
}
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current schema only validates the agent.flavor property. To make the schema validation more robust and prevent configuration errors, it is highly recommended to expand the schema to cover other critical properties defined in values.yaml, such as global.imageRegistry and controller.replicas (which should be a positive integer).

  "properties": {
    "global": {
      "type": "object",
      "properties": {
        "imageRegistry": {
          "type": "string"
        }
      }
    },
    "agent": {
      "type": "object",
      "properties": {
        "flavor": {
          "type": "string",
          "enum": [
            "base",
            "metax"
          ],
          "default": "base"
        }
      }
    },
    "controller": {
      "type": "object",
      "properties": {
        "replicas": {
          "type": "integer",
          "minimum": 1
        }
      }
    }
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant