feat: complete ocp_binaries and rhcos Validate() with upstream checks…#12
Merged
Merged
Conversation
…um verification Validate() previously only checked if local files could be hashed, without comparing against expected checksums. Now it re-fetches sha256sum.txt for each configured version and verifies every file, matching the pattern used by ClientsProvider. Also adds SetValidationProgress support for live UI progress, fixes Type() return values, and cleans up misleading "stub" comments on Sync() methods. https://claude.ai/code/session_01SdEa9sX3wtA8Haq92LiCry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…um verification
Validate() previously only checked if local files could be hashed, without comparing against expected checksums. Now it re-fetches sha256sum.txt for each configured version and verifies every file, matching the pattern used by ClientsProvider. Also adds SetValidationProgress support for live UI progress, fixes Type() return values, and cleans up misleading "stub" comments on Sync() methods.
https://claude.ai/code/session_01SdEa9sX3wtA8Haq92LiCry