Skip to content

Enable alpha test when using vertex alpha in some cases#15504

Closed
bghgary wants to merge 3 commits into
BabylonJS:masterfrom
bghgary:alpha-test-fix
Closed

Enable alpha test when using vertex alpha in some cases#15504
bghgary wants to merge 3 commits into
BabylonJS:masterfrom
bghgary:alpha-test-fix

Conversation

@bghgary

@bghgary bghgary commented Aug 30, 2024

Copy link
Copy Markdown
Contributor

This change addresses some edge cases tested by a new test model in the glTF sample assets repo: KhronosGroup/glTF-Sample-Assets#146.

The issue is that alpha test is not taking into account whether a mesh has vertex alpha or not.

Before:
image

After:
image

TODO

  • Add test once new test model is merged

@bghgary bghgary requested a review from sebavan August 30, 2024 16:18
@bjsplat

bjsplat commented Aug 30, 2024

Copy link
Copy Markdown
Collaborator

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Comment thread packages/dev/core/src/Materials/material.ts
@bjsplat

bjsplat commented Aug 30, 2024

Copy link
Copy Markdown
Collaborator

@bjsplat

bjsplat commented Aug 30, 2024

Copy link
Copy Markdown
Collaborator

@bjsplat

bjsplat commented Aug 30, 2024

Copy link
Copy Markdown
Collaborator

@bjsplat

bjsplat commented Sep 5, 2024

Copy link
Copy Markdown
Collaborator

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15504/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat

bjsplat commented Sep 5, 2024

Copy link
Copy Markdown
Collaborator

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15504/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@github-actions

github-actions Bot commented Oct 4, 2024

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale because it has been inactive for more than 14 days. Please update to "unstale".

@github-actions github-actions Bot added the stale label Oct 4, 2024
@bghgary

bghgary commented Oct 28, 2024

Copy link
Copy Markdown
Contributor Author

Closing in favor of #15573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants