Rework instantiation of MotionBuilderConfigOverlay#208
Merged
Conversation
…n_builder_to_display() to do just that
…fault_motion_builder() ... the latter only generates a default MotionBuilder if the popup did NOT start with one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the instantiation of
MotionBuilderConfigOverlaysuch that a validMotionBuilderobject is instantiated and linked to the display by the end of__init__.The generated
MotionBuilderobject is either a copy of the motion build attached to the givenMotionGroupor (ifMotionGrouphas no motion builder) a default motion builder defined by the_default_motion_builder()method._init_*methods to be list alphabetically._init_motion_builderto do the fullMotionBuilderinstantiation._init_mspace_displayto do theMotionSpaceDisplayinstantiation.link_motion_builder_to_displayto do the associated linking._initialized_motion_builderinto_default_motion_builder. Now,_init_motion_builderdoes the full instantiation and_default_motion_builderjust gives the default motion builder (as needed).skip_assignmentto_spawn_motion_builderso "spawn" can be used by_default_motion_builderand (thus)_init_motion_builder.