Skip to content

Define role already granted - #624

Open
d3v-active wants to merge 3 commits into
BCPathway:mainfrom
d3v-active:define-role-already-granted
Open

Define role already granted#624
d3v-active wants to merge 3 commits into
BCPathway:mainfrom
d3v-active:define-role-already-granted

Conversation

@d3v-active

@d3v-active d3v-active commented Jul 29, 2026

Copy link
Copy Markdown

Closes #431

Added RoleAlreadyGranted Error Code: Introduced AdminError::RoleAlreadyGranted (= 7) to the AdminError enum inside the admin core module (contracts/admin/src/lib.rs). This clearly distinguishes between an invalid grant versus other failures.
Added Validation Check in Role Assignment: Integrated a new validation step within the internal _grant_role function. It now proactively checks has_role(env, role, address) and safely panics with RoleAlreadyGranted if the target address already holds the requested role.

Why this change was made
Previously, re-granting an already held role would overwrite the existing persistent storage state and extend the time-to-live unnecessarily without indicating to the caller that the role was already granted. This explicit failure ensures strict access control logic, optimizes gas by failing early, and guarantees that no redundant storage modifications are processed.

Acceptance Criteria met
Function logic operates securely: The state change is strictly guarded; the function aborts before interacting with the persistent ledger storage.
Events/Errors are properly defined/emitted: Added the specific error RoleAlreadyGranted alongside existing errors.
No unauthorized state modifications: Stops duplicate grants from being recorded or triggering duplicate grant events.

@drips-wave

drips-wave Bot commented Jul 29, 2026

Copy link
Copy Markdown

@d3v-active Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Admin Core] Define error RoleAlreadyGranted

1 participant